Firefox OS/Comms/Dialer/Sprint/v2.1-S5/20140923-StandupNotes

Admin:
- I moved all the meeting calendar invites to a public calendar, "Firefox OS Dialer". See: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Calendar
Next steps:
- bug 1062799 - Call information is not updated on the fly after creating a contact
  - Have to review this for Jorge.
- bug 1065302 - Contact phone numbers and phone type should always be separated with a comma
  - Have to review this for Jorge.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
  - Going to work on this.
- bug 1060730 - Turn updateICEContacts() into a Promise.all() barrier
  - Might take this from Germán if he can't do it during this sprint.
- bug 1061398 - Incall keypad layout needs adjustment
  - Gave feedback for Paco. Another version is up which I need to review.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
  - Going to investigate this. It looks like a graphics issue.
Done:
- bug 1037868 - Create gaia-sim-picker component
  - Posted a new patch for Anthony to review.
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
  - Posted a new patch which I'll ask to be reviewed after bug 1037868 lands.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  - Review+ for Paco/Germán, requested feedback from Anthony.
- bug 1069439 - ICE contacts don't show up on emergency call screen
  - Uplifted to v2.1.

Closed bug 1061616, a 2.1 blocker per the latest feedback from QA.
bug 1042562 Move facebook specific code from suggestion_bar.js to shared/js/contact.js
- We can't remove code here but we could structure it better. Leaving it for later.
Started working on bug 1056943. I think the progress bar update will be annoying. Also, the DB upgrades are not unit tested :(
Reviews
- bug 1037868

Tomorrow (september 24) is free day in Barcenlo

bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I created this bug 1069836 as follow up for fixing the localization
- We have asked for review
bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- <drs> I will get this actionable again, or at least clarify what they need. It looks like they don't want to make a decision on it yet.
bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- <drs> I don't think we have to push this yet; we can wait for bug 977588 to land and then ask Carrie again if she hasn't responded by then. I think she's waiting to see what it looks like first.
bug 1061398 - Incall keypad layout needs adjustment
- I have worked on it. PR on bug.
bug 1060293 - Remove dialer's buttons.css and use styling from shared/styles/buttons.css instead
- I just start, only I have made a test for understand the issue.
I am starting with set up of styleDocco

bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
bug 1068109 to restore the 2s delay before the call screen goes away.
- I have incorporated the main suggestions and am testing right now. I ran into a few bugs which I thought were related to my changes, but I could repro on master, so I've filed bug 1071607 and bug 1071578. There is also one intermittent issue I've seen with an incoming call where the CLID and the word "incoming" is not displayed, but I cannot repro.

bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- Need to do changes.
bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- Waiting <drs> feedback.
bug 1062799 - Call information is not updated on the fly after creating a contact
- Starting to work in this bug.
- Patch done, working in tests.
- Test done, I will upload the patch tomorrow.
- Patch and tests waiting to review

// Part-time people (not required to update this)

Contents