Firefox OS/Comms/Dialer/Sprint/v2.1-S5
From MozillaWiki
< Firefox OS | Comms | Dialer | Sprint
Contents
- 1 Bugs
- 2 Daily Standup Meetings
- 3 PTO
- 4 Retrospective
- 5 Demos
Bugs
Status
- 23,26,23,26,25,22,19,19,19,18
Bugs Taken in Planning
ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
983766 | Cristian Rodriguez (:crdlc) | [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers | --- | No cf_feature-b2g | [planned-sprint] | RESOLVED | FIXED |
1029142 | Gabriele Svelto [:gsvelto] | Call log deletions don't persist after killing the app | --- | No cf_feature-b2g | [planned-sprint c=3] | RESOLVED | DUPLICATE |
1060730 | Germán Toro del Valle (:gtorodelvalle) | Turn updateICEContacts() into a Promise.all() barrier | --- | No cf_feature-b2g | [planned-sprint] | RESOLVED | FIXED |
1061616 | Anthony Ricaud (:rik) | call log is not showing recently dialled numbers | 2.1+ | No cf_feature-b2g | [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] | VERIFIED | FIXED |
1061623 | David Garcia [:davidg][retired] | Write tests for ticker updates on the call screen | --- | No cf_feature-b2g | [planned-sprint] | RESOLVED | FIXED |
5 Total; 0 Open (0%); 4 Resolved (80%); 1 Verified (20%);
- Does not include Bugs Taken but not Completed.
Bugs Taken but not Completed
ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
1060451 | Doug Sherk (:drs) (inactive) | Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js | --- | No cf_feature-b2g | [planned-sprint c=6][in-sprint=v2.1-S5] | RESOLVED | FIXED |
1068106 | Doug Sherk (:drs) (inactive) | Evaluate acquiring screen wake lock from callscreen when a call ends | --- | No cf_feature-b2g | [planned-sprint c=1][in-sprint=v2.1-S5] | RESOLVED | WONTFIX |
2 Total; 0 Open (0%); 2 Resolved (100%); 0 Verified (0%);
Bugs Taken During Sprint
ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
1061614 | Gabriele Svelto [:gsvelto] | Call log database upgrade path to schema 4 wrongly puts calls one week apart in the same group | --- | No cf_feature-b2g | RESOLVED | FIXED | |
1065147 | Anthony Ricaud (:rik) | [Dialer] DTMF volume is reduced significantly and cannot be increased after a call | 2.1+ | No cf_feature-b2g | [caf priority: p2][2.1-flame-test-run-2][CR 726380] | VERIFIED | FIXED |
1065302 | Jorge Prudencio [:jorgep] | Contact phone numbers and phone type should always be separated with a comma | --- | No cf_feature-b2g | VERIFIED | FIXED | |
1066869 | (inactive after 6/18) Alive Kuo [:alive] | [Contacts] Contact photo does not appear when receiving a call. | 2.1+ | No cf_feature-b2g | [caf priority: p2][CR 723665][2.1-flame-test-run-2] | VERIFIED | FIXED |
1069439 | Doug Sherk (:drs) (inactive) | ICE contacts don't show up on emergency call screen | 2.1+ | No cf_feature-b2g | VERIFIED | FIXED | |
1070825 | Tzu-Lin Huang [:dwi2][:tzhuang] | [Dialer] Connect multiple way calls with same number but difference extension number. | 2.0M+ | No cf_feature-b2g | VERIFIED | FIXED | |
1073534 | Doug Sherk (:drs) (inactive) | "cancel" is a non-localizable string in the audio output picker | 2.1+ | No cf_feature-b2g | RESOLVED | FIXED |
7 Total; 0 Open (0%); 2 Resolved (28.57%); 5 Verified (71.43%);
All Issues for this Sprint
ID | Assigned to | Summary | Blocking b2g | Feature b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
983766 | Cristian Rodriguez (:crdlc) | [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers | --- | --- | [planned-sprint] | RESOLVED | FIXED |
1029142 | Gabriele Svelto [:gsvelto] | Call log deletions don't persist after killing the app | --- | --- | [planned-sprint c=3] | RESOLVED | DUPLICATE |
1060730 | Germán Toro del Valle (:gtorodelvalle) | Turn updateICEContacts() into a Promise.all() barrier | --- | --- | [planned-sprint] | RESOLVED | FIXED |
1061614 | Gabriele Svelto [:gsvelto] | Call log database upgrade path to schema 4 wrongly puts calls one week apart in the same group | --- | --- | RESOLVED | FIXED | |
1061616 | Anthony Ricaud (:rik) | call log is not showing recently dialled numbers | 2.1+ | --- | [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] | VERIFIED | FIXED |
1061623 | David Garcia [:davidg][retired] | Write tests for ticker updates on the call screen | --- | --- | [planned-sprint] | RESOLVED | FIXED |
1065147 | Anthony Ricaud (:rik) | [Dialer] DTMF volume is reduced significantly and cannot be increased after a call | 2.1+ | --- | [caf priority: p2][2.1-flame-test-run-2][CR 726380] | VERIFIED | FIXED |
1065302 | Jorge Prudencio [:jorgep] | Contact phone numbers and phone type should always be separated with a comma | --- | --- | VERIFIED | FIXED | |
1066869 | (inactive after 6/18) Alive Kuo [:alive] | [Contacts] Contact photo does not appear when receiving a call. | 2.1+ | --- | [caf priority: p2][CR 723665][2.1-flame-test-run-2] | VERIFIED | FIXED |
1069439 | Doug Sherk (:drs) (inactive) | ICE contacts don't show up on emergency call screen | 2.1+ | --- | VERIFIED | FIXED | |
1070825 | Tzu-Lin Huang [:dwi2][:tzhuang] | [Dialer] Connect multiple way calls with same number but difference extension number. | 2.0M+ | --- | VERIFIED | FIXED | |
1073534 | Doug Sherk (:drs) (inactive) | "cancel" is a non-localizable string in the audio output picker | 2.1+ | --- | RESOLVED | FIXED |
12 Total; 0 Open (0%); 6 Resolved (50%); 6 Verified (50%);
- Does not include Bugs Taken but not Completed.
Bugs Redirected
ID | Assigned to | Summary | Blocking b2g | Feature b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
983766 | Cristian Rodriguez (:crdlc) | [B2G][Dialer] Suggested phone numbers don't appear for Facebook contacts that have edited phone numbers | --- | --- | [planned-sprint] | RESOLVED | FIXED |
1029142 | Gabriele Svelto [:gsvelto] | Call log deletions don't persist after killing the app | --- | --- | [planned-sprint c=3] | RESOLVED | DUPLICATE |
1037868 | Doug Sherk (:drs) (inactive) | Create gaia-sim-picker component | --- | --- | [planned-sprint c=6][in-sprint=v2.1-S2] | RESOLVED | FIXED |
1060730 | Germán Toro del Valle (:gtorodelvalle) | Turn updateICEContacts() into a Promise.all() barrier | --- | --- | [planned-sprint] | RESOLVED | FIXED |
1061616 | Anthony Ricaud (:rik) | call log is not showing recently dialled numbers | 2.1+ | --- | [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] | VERIFIED | FIXED |
1061623 | David Garcia [:davidg][retired] | Write tests for ticker updates on the call screen | --- | --- | [planned-sprint] | RESOLVED | FIXED |
6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);
Daily Standup Meetings
- Current hosts: drs, gtorodelvalle, thills
- Hosts rotate every week.
- If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
- Start by pinging everyone who should be participating.
- List any administrative items you have, and then ask for more from other people (look at the Etherpad).
- Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
- Move to individual updates. Go alphabetically, in descending order.
- If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
- Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
- Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.
Day 10: September 29
Blockers
- 2.1+ bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- Assigned to Tamara. Looks like this is related to bug 927862.
- 2.1? bug 1073534 - "cancel" is a non-localizable string in the audio output picker
- Landed a fix.
drs
- Admin:
- Nothing new.
- Next steps:
- bug 1068109 - Restore 2s delay before callscreen is closed
- Have to review this for Tamara.
- bug 1061398 - Incall keypad layout needs adjustment
- Gave feedback-. Have to give feedback today for Paco.
- bug 1070808 - [ secure/hidden ]
- Have to review this for Tzu-Lin.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- In progress. I expect to have a patch today.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Kats doesn't have a device for this, so I will investigate if I have time.
- bug 1068109 - Restore 2s delay before callscreen is closed
- Done:
- Did pre-sprint and sprint planning.
- bug 1069286 - No tactile feedback when dialling a number
- Review+ for Anthony.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Review- for Jorge.
- bug 1061398 - Incall keypad layout needs adjustment
- Feedback+ for Paco.
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
- Waiting for Anthony, Francisco to review
- bug 1073534 - "cancel" is a non-localizable string in the audio output picker
- Landed 2 patches for master and v2.1.
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away.
- Finished off incorporating changes for the patch from last review & submitted.
- bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- qdot is looking at this from settings perspective and there are some ideas floating around there, qa is requested, but wanted to discuss what next steps should be on this one as it's masked by 1068109, but not sure what we should do to move this forward.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
Day 9: September 26
Blockers
- 2.1+ bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Redirected to APZ component. Doug is going to investigate anyways.
- 2.1+ bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- Assigned to Tamara. Looks like this is related to bug 927862.
- 2.1? bug 1073534 - "cancel" is a non-localizable string in the audio output picker
- Unassigned. Looks easy.
drs
- Admin:
- Organized next bug triages.
- Next steps:
- bug 1061398 - Incall keypad layout needs adjustment
- Gave feedback-. Have to give feedback today for Paco.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Have to review this for Jorge.
- bug 1070808 - [ secure/hidden ]
- Have to review this for Tzu-Lin.
- bug 1073534 - "cancel" is a non-localizable string in the audio output picker
- Taking this today.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- In progress. I expect to have a patch today.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Kats doesn't have a device for this, so I will investigate if I have time.
- bug 1061398 - Incall keypad layout needs adjustment
- Done:
- Organized and ran bug bash.
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
- Posted a patch for Anthony, Francisco, Julien, and Yuren to review.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Review- for Jorge.
- bug 1068109 - Restore 2s delay before callscreen is closed
- Review- for Tamara.
- bug 1052136 - Clean up mozL10n API use in Communications
- Review+ for Zibi.
Rik
- Asked help from bent for bug 1056943, remove contact pictures from call log db
- bug 1069981 keep missed call notifications quiet needs changes from bug 1066385. Trying to get the system to do what we need for this.
- Reviews
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away.
- Today, I'm incorporating the changes into the tests. Need some helps/clarifications from drs to finish this off.
- bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- Did some testing on this y'day and found that rik's hypothesis is correct that the 2s delay bug resolves this. Or rather, it masks it.
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
Day 8: September 25
Note
Most updates where given over Vidyo, before our bug bash.
Blockers
- 2.1+ bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Redirected to APZ component. Doug is going to investigate anyways.
- 2.1? bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- Unassigned. Looks like this is related to bug 927862.
drs
- Admin:
- The bug bash is today! Etherpad: https://etherpad.mozilla.org/fxos-dialer-bug-bash
- Next steps:
- bug 1068109 - Restore 2s delay before callscreen is closed
- Have to review this for Tamara.
- bug 1061398 - Incall keypad layout needs adjustment
- Have to give feedback for Paco.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- In progress. I expect to have a patch today.
- bug 1060730 - Turn updateICEContacts() into a Promise.all() barrier
- Might take this from Germán if he can't do it during this sprint.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Kats doesn't have a device for this, so I will investigate if I have time.
- bug 1068109 - Restore 2s delay before callscreen is closed
- Done:
- bug 1037868 - Create gaia-sim-picker component
- Landed!
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
- Posted a patch for Anthony, Francisco, Julien, and Yuren to review.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Provided info for Jorge for testing.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Review- for Jorge.
- bug 1037868 - Create gaia-sim-picker component
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
thills
- Absent/no report
jpruden92
- Absent/no report
Day 7: September 24
Blockers
- 2.1+ bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Redirected to APZ component
drs
- Admin:
- Please add your devices and SIMs to the bug bash Etherpad: https://etherpad.mozilla.org/fxos-dialer-bug-bash
- Next steps:
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- In progress. I expect to have a patch today.
- bug 1060730 - Turn updateICEContacts() into a Promise.all() barrier
- Might take this from Germán if he can't do it during this sprint.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Review- for Jorge, info needed for next iteration.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Have to review this for Jorge.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- Done:
- bug 1061398 - Incall keypad layout needs adjustment
- Canceled review for Paco. There are some issues with this that I found during testing.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Got redirected to APZ component.
- bug 1065302 - Contact phone numbers and phone type should always be separated with a comma
- Review+ for Jorge, landed.
- bug 1037868 - Create gaia-sim-picker component
- Posted a new patch for Anthony to review.
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
- Waiting for bug 1037868 to be reviewed before requesting review for this.
- bug 1061398 - Incall keypad layout needs adjustment
Rik
- Struggling with IndexedDB migrations for bug 1056943
- Triaging new bugs
- Reviews
gtorodelvalle
- Administrative:
- The Firefox OS Telefónica have a general meeting next Monday, the 29th, from 15:00 CEST on, so we won't be able to make it for the spring planning. Do you think it may be worth it to move to Monday's morning? The meeting continues on Tuesday all day long :(
- I have basically been helping Paco and Jorge with some bugs. Hope I can start getting rid of mines soon :S
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away.
- Rec'd feedback from drs on this. Now focusing on unit tests for this.
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- Need to do changes.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Solution changed, waiting <drs> review.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Solution changes, waiting NI
pacorampas
- Absent/no report
Day 6: September 23
Blockers
- 2.1+ bug 1061616 - call log is not showing recently dialled numbers
- Resolved as QA can't repro anymore.
- 2.1+ bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Assigned to Doug, qawanted for better STR and video. => [jlorenzo] STR and video updated
drs
- Admin:
- I moved all the meeting calendar invites to a public calendar, "Firefox OS Dialer". See: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Calendar
- Next steps:
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Have to review this for Jorge.
- bug 1065302 - Contact phone numbers and phone type should always be separated with a comma
- Have to review this for Jorge.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- Going to work on this.
- bug 1060730 - Turn updateICEContacts() into a Promise.all() barrier
- Might take this from Germán if he can't do it during this sprint.
- bug 1061398 - Incall keypad layout needs adjustment
- Gave feedback for Paco. Another version is up which I need to review.
- bug 1070993 - Entering or scrolling in call log sometimes shows empty list
- Going to investigate this. It looks like a graphics issue.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Done:
- bug 1037868 - Create gaia-sim-picker component
- Posted a new patch for Anthony to review.
- bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
- Posted a new patch which I'll ask to be reviewed after bug 1037868 lands.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Review+ for Paco/Germán, requested feedback from Anthony.
- bug 1069439 - ICE contacts don't show up on emergency call screen
- Uplifted to v2.1.
- bug 1037868 - Create gaia-sim-picker component
Rik
- Closed bug 1061616, a 2.1 blocker per the latest feedback from QA.
- bug 1042562 Move facebook specific code from suggestion_bar.js to shared/js/contact.js
- We can't remove code here but we could structure it better. Leaving it for later.
- Started working on bug 1056943. I think the progress bar update will be annoying. Also, the DB upgrades are not unit tested :(
- Reviews
pacorampas
Tomorrow (september 24) is free day in Barcenlo
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I created this bug 1069836 as follow up for fixing the localization
- We have asked for review
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- <drs> I will get this actionable again, or at least clarify what they need. It looks like they don't want to make a decision on it yet.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- <drs> I don't think we have to push this yet; we can wait for bug 977588 to land and then ask Carrie again if she hasn't responded by then. I think she's waiting to see what it looks like first.
- bug 1061398 - Incall keypad layout needs adjustment
- I have worked on it. PR on bug.
- bug 1060293 - Remove dialer's buttons.css and use styling from shared/styles/buttons.css instead
- I just start, only I have made a test for understand the issue.
- I am starting with set up of styleDocco
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away.
- I have incorporated the main suggestions and am testing right now. I ran into a few bugs which I thought were related to my changes, but I could repro on master, so I've filed bug 1071607 and bug 1071578. There is also one intermittent issue I've seen with an incoming call where the CLID and the word "incoming" is not displayed, but I cannot repro.
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- Need to do changes.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- Waiting <drs> feedback.
- bug 1062799 - Call information is not updated on the fly after creating a contact
- Starting to work in this bug.
- Patch done, working in tests.
- Test done, I will upload the patch tomorrow.
- Patch and tests waiting to review
// Part-time people (not required to update this)
gtorodelvalle
- Absent/no report
Day 5: September 22
drs
- Admin:
- Nothing new.
- Next steps:
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Going to investigate this.
- bug 1037868 - Create gaia-sim-picker component
- Started fixing this after Anthony's high-level comments.
- bug 1061398 - Incall keypad layout needs adjustment
- Need to review this for Paco.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Need to review this for Paco/Germán.
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Done:
- bug 1069989 - Incoming call missing text and duration counter when built with APP=callscreen make install-gaia
- Helped with repro.
- bug 1069439 - ICE contacts don't show up on emergency call screen
- Fixed code review comments and landed.
- bug 1068109 - Restore 2s delay before callscreen is closed
- Feedback- for Tamara, suggested some large structural changes.
- bug 1069989 - Incoming call missing text and duration counter when built with APP=callscreen make install-gaia
Rik
- Currently reviewing bug 1037868, sim picker web component
- Filed bug 1069981 about a UX improvement when not answering calls
- Reviews
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I created this bug 1069836 as follow up for fixing the localization
- We have asked for review
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- <drs> I will get this actionable again, or at least clarify what they need. It looks like they don't want to make a decision on it yet.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- <drs> I don't think we have to push this yet; we can wait for bug 977588 to land and then ask Carrie again if she hasn't responded by then. I think she's waiting to see what it looks like first.
- bug 1061398 - Incall keypad layout needs adjustment
- NI for knowing what is the decision for fixing it
- bug 1060293 - Remove dialer's buttons.css and use styling from shared/styles/buttons.css instead
- I just start, only I have made a test for understand the issue.
- I am starting with set up of styleDocco
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away.
- I'm working today on drs feedback for the SoC on this bug.
Blockers
- Absent/no report
gtorodelvalle
- Absent/no report
jpruden92
- Absent/no report
Day 4: September 19
Blockers
- 2.1+ bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
drs
- Admin:
- Today is the last day to fix 2.1 blockers.
- We will effectively have no blockers/noms that are in our hands after the standup and I land bug 1069439.
- Next steps:
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Going to investigate this.
- bug 1037868 - Create gaia-sim-picker component
- Started fixing this after Anthony's high-level comments.
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Done:
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Review- for Paco/Germán.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Feedback- for Jorge.
- bug 1069439 - ICE contacts don't show up on emergency call screen
- Filed and posted a patch for Anthony to review.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
Rik
- Landed bug 1065147, a 2.1 blocker
- Went through some new bugs to triage them, make them actionable
- Reviewed bug 1069439
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I created this bug 1069836 as follow up for fixing the localization
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- <drs> I will get this actionable again, or at least clarify what they need. It looks like they don't want to make a decision on it yet.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- <drs> I don't think we have to push this yet; we can wait for bug 977588 to land and then ask Carrie again if she hasn't responded by then. I think she's waiting to see what it looks like first.
- bug 1061398 - Incall keypad layout needs adjustment
- Comment in bugzilla
- bug 1060293 - Remove dialer's buttons.css and use styling from shared/styles/buttons.css instead
- I just start, only I have made a test for understand the issue.
- I am starting with set up of styleDocco
thills
- Bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- Bug 1068109 to restore the 2s delay before the call screen goes away.
- Put a patch for feedback which drs has looked at. Working on tests for this right now and have a different refactoring to address the SoC. I added back some of the code I removed for the transition as that probably does not belong as part of this patch.
- Bug 1069329 - Filed this one today to get some feedback from Carrie as to whether we have enough of an indicator to a user that they have an active call going on.
jpruden92
- Bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- Need to do changes.
- Bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- Waiting <drs> feedback.
- Bug 1062799 - Call information is not updated on the fly after creating a contact
- Starting to work in this bug.
- Patch done, working in tests.
Day 3: September 18
Blockers
- 2.1+ bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
- 2.1+ bug 1065147 - [Dialer] DTMF volume is reduced significantly and cannot be increased after a call
- Currently assigned to Gabriele, needinfo set on Etienne as bug 1061012 caused this.
- 2.2? bug 1068686 - [Dialer] Touch tone audio error when typing any number
- Low priority, but a new blocker nom.
drs
- Admin:
- I sent out an invite for the bug bash.
- Next steps:
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Going to investigate this.
- bug 1037868 - Create gaia-sim-picker component
- Started fixing this after Anthony's high-level comments.
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Done:
- Did a bit of work outside the dialer. bug 970093, if you're curious.
- Planned bug bash.
- Sent out meeting summary for office hour.
- bug 1068109 - Restore 2s delay before callscreen is closed
- Feedback+ for Tamara.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Started review, will finish tomorrow.
Rik
- Admin : 2.1 blockers should be fixed by tomorrow
- Looking at 2.1 blocker bug 1065147. I think it's a small typo, will confirm soon.
- Tried to quickly fix bug 1069236 but adding some classes was not working so I'm asking for the visual spec.
- Reviews:
pacorampas
- Absent/no report
Day 2: September 17
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
- bug 1065147 - [Dialer] DTMF volume is reduced significantly and cannot be increased after a call
- Currently assigned to Gabriele, needinfo set on Etienne as bug 1061012 caused this.
drs
- Admin:
- I might not be able to make it to the standup or office hour today as I have an urgent dental appointment during this time.
- Next steps:
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Going to investigate this.
- bug 1037868 - Create gaia-sim-picker component
- Need to fix this after Anthony's high-level comments.
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Done:
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- Got this going again. Looks like we have nothing to do here.
- bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
- Review+, waiting for a couple of tiny changes before landing.
- bug 1061398 - Incall keypad layout needs adjustment
- Provided a new suggestion/feedback for Paco.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number” message
- Landed for Jorge after a small fix.
- bug 1030346 - Improve accessibility for of the contacts app
- Helped with uplift, indirectly related to bug 1059087.
- bug 1024341 - Wake up the device after a call hangs up
- Discussed with Anthony and Tamara, broke this up into sub-bugs that are easier to track.
- bug 1068224 - Limit the amount of calls shown in the call info view
- Reported and organized questions for UX.
- Going to be mentoring Rigin, our first volunteer contributor since I-have-no-idea-when.
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
gtorodelvalle
- Administrative:
- SADLY I WON'T BE ABLE TO CONNECT TO THE DAILY LONG :( I will use Etherpad to report and please feel free to contact me via IRC any other time ;) Thanks!
- If the dailies are now at 14:30 CEST, I think I can make them :)
- Back from holidays. Spent yesterday to catch up with emails and messages.
- <drs> Welcome back! I hope you enjoyed your vacation.
- Thanks Doug!!! I really did ;)
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
- Helping Paco with this bug.
- Left some comments in Github for Doug :)
- New review asked from Doug.
- Apart from helping Paco, I have not been able to do really productive due to retaking responsibilities after holidays, organising talks for the forthcoming TEFCon conference to be held in November and finalising the contents for a course to be given in Telefónica about the latests novelties and additions in Web Technologies :) Hope to get back up and running ASAP ;)
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- New review? :) (I cross my fingers)
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- <drs> I will get this actionable again, or at least clarify what they need. It looks like they don't want to make a decision on it yet.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- <drs> I don't think we have to push this yet; we can wait for bug 977588 to land and then ask Carrie again if she hasn't responded by then. I think she's waiting to see what it looks like first.
- bug 1061398 - Incall keypad layout needs adjustment
- Comment in bugzilla
- I am starting with set up of styleDocco
thills
- bug 1024341 - Wakeup the device after call hangs up
- We split this into several bugs. Right now, I'm working on one of the child bugs of this.
- bug 1068109 to restore the 2s delay before the call screen goes away. I seem to have one potential solution for this and testing it to see if it's really viable.
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- Need to do changes.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Landed and merged
Rik
- Absent/no report
Day 1: September 16
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
- bug 1065147 - [Dialer] DTMF volume is reduced significantly and cannot be increased after a call
- New blocker, currently unassigned. Maybe Gabriele knows something about this.
drs
- Admin:
- Welcome back, Anthony.
- The Etherpad is completely messed up. Please fix your sections by cutting and pasting the whole thing. Sorry about that!
- Next steps:
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Going to investigate this.
- bug 1066869 - [Contacts] Contact photo does not appear when receiving a call.
- Going to investigate this.
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- Going to get this actionable again.
- bug 1037868 - Create gaia-sim-picker component
- Need to fix this after Anthony's high-level comments.
- bug 1067263 - [call log]When save two different call records to a contact, interface of two call numbers in call log show the same
- Done:
- Did sprint planning, and followup work.
- Contacted Bhavana about adding a "suggested landing" section to the B2G_Landing page to avoid what happened with 2.1 FL being earlier than anticipated.
- bug 1053641 - [b2g][2.0] "call forwarding status" page string format has problem.
- Review+ for Gabriele, landed.
- bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
- Helped with figuring out how to stub Performance.now(). It's going to come back to me for review at some point.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Got approval for v2.1 with bug 1030346.
- bug 1061398 - Incall keypad layout needs adjustment
- Gave feedback for Paco. We need VD input from Carol before we can continue here.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number” message
- Review+ for Jorge.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and ‘Label'
- Uplifted to v2.1, provided some help with bug 1030346, its dependency.
Rik
- Catching up on your activites (email and such)
- Comms sprint meeting
- Will take a look at the 2.0 blocker, bug 1066869 Contact photo does not appear when receiving a call
- Will work on the 2.1 blog post tomorrow
gtorodelvalle
- Administrative:
- SADLY I WON'T BE ABLE TO CONNECT TO THE DAILY LONG :( I will use Etherpad to report and please feel free to contact me via IRC any other time ;) Thanks!
- Back from holidays. Spent yesterday to catch up with emails and messages.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
- Helping Paco with this bug.
- Left some comments in Github for Doug :)
- We'll ask for a new review from Doug ASAP.
thills
- bug 1024341 - Wakeup the device after call hangs up
- Have some feedback from Carrie to make it pause for a bit on the duration screen.
- I'm debugging on the CallScreen right now trying to understand where to make it pause. It seems that we are getting multiple CloseWindow calls. This seems to shutdown the app very quickly and causes some of the code in handled_call.js not to execute. Might need a discussion after the standup.
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- Need to do changes.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Patch made. Waiting to review.
- Improving the solution. Modifying tests.
- Need final review
pacorampas
- Absent/no report
PTO
- davidg: none
- drs: Sep 26, tentative
- gsvelto: none
- gtorodelvalle: ?
- jpruden92: ?
- paco: ?
- Rik: ?
- thills: none
Retrospective
Things we did well
- <drs> This was a nice and relaxed sprint, and we didn't get many blockers.
- <davidg> Managed to get bugs on time
Things we could do better
- <drs> Dialer has ~550 bugs open at any given time: https://bugzilla.mozilla.org/buglist.cgi?component=Gaia%3A%3ADialer&list_id=11111500&product=Firefox%20OS&query_format=advanced&resolution=---&order=bug_id&limit=0
- <drs> Thoughts on doing a bug bash? I know it's not fun, but a lot of these bugs are ancient and it will probably be as simple as resolving them or duping them.
- <thills> I would like to do it. Would be good to set aside a time where we can all work on it at the same time.
- <drs> We didn't do any demos this last sprint. I'm wondering if anyone sees any value in them. We asked this last time but maybe the answer has changed. If we decide to get back to doing them, I will really start pushing it this sprint for anything demoable.
- <thills> do we have a blog to go along with this? I'm not sure it's for us directly, but others outside the team.
- <drs> Anthony was going to, but I don't know if we got enough demos, or if he had time.
- <davidg> A bug that was late-l10n was just landed at the very last moment, but it was ready much before.
- <drs> Suggestions?
- <davidg> When the bug get blocked by a deadlock discussion, just try to unlock it. Pretty much what we did at the end but earlier.
- <drs> Yeah, sometimes it's hard to know the state of everything. I noticed that this was blocked a bit later because it didn't seem blocked on the surface a few days before. It would help if this was mentioned in daily meetings and notes.
- <davidg> I should probably tried to propose a solution instead of just watch them argue :)
- <drs> It's ok, it's hard to know what to do all the time. Just mention it in the daily. Either way it was ok, it would have just been nice to be unblocked sooner.
Action items
- <drs> We have not been doing enough to get contributors engaged. I've talked with Francisco who actively sets himself as a mentor on many bugs and provides and plan and support for contributors. I'm going to begin doing this and I suggest that others do the same as well.
- <gsvelto> I've set myself up as a mentor on a number of bugs but none dialer-related IIRC. Most of those are code cleanup & factoring out shared pieces as those are easy for new contributors and not high priority. We could start by filing some of those as there's many parts of the dialer that could use some love. Additionally if a bug needs an easy follow up it's always best to set it as a mentored one (e.g. remove a workaround, polish some unit-tests, etc...).
- <davidg> Maybe we should invite Jorge and Francisco to join dailys
- <drs> I did I think. I should double-check that.
- <drs> Do a bug bash.
- <drs> Have a 2.2 phone and 2.0 or 2.1 ready to test bugs.
- <drs> Really push for demos and do a blog post.
- <drs> Continue doing office hours.
Demos
- bug 1053641 - "call forwarding status" page string format has problem.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
(screencast) No message appears when you tap on the suggestion area
- bug 1065302 - Contact phone numbers and phone type should always be separated with a comma.