Firefox OS/Comms/Dialer/Sprint/v2.2-S7/20140303-StandupNotes
From MozillaWiki
< Firefox OS | Comms | Dialer | Sprint
Contents
drs
- Admin:
- Nothing new.
- Next steps:
- bug 1133621 - [RTL][Dialer] Vertical scrollbar appears shortly at left side of prompt text.
- Going to investigate.
- bug 1133621 - [RTL][Dialer] Vertical scrollbar appears shortly at left side of prompt text.
- Patches:
- Nothing new.
- Reviews:
- bug 1125409 - [Dialer] Double Tapping the Add Contact button will bring up the context menu twice.
- r?
- bug 1017966 - [Flame][V1.4][Dialer]There is no prompts when you tap on "Call" without any number in the dialer field.
- r?
- bug 1068224 - Limit the amount of calls shown in the call info view
- f?
- bug 1125409 - [Dialer] Double Tapping the Add Contact button will bring up the context menu twice.
- Other:
- bug 1094764 - Implement AudioContext.suspend and friends
- This is landing soon. It’ll help us simplify our code a bit.
- New ServiceWorker architecture for Contacts app: https://github.com/fxos/contacts
- bug 1094764 - Implement AudioContext.suspend and friends
thills
- Admin - None
- bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
- this has a problem where it’s truncating the number with multiple calls when it shouldn’t be. Need to fix this
- bug 1135067 - Landed. Need to ask for Uplift.
- bug 1134961 - I have a line on fix for this one.
- wrapping in bdi fixes the + direction in rtl.
- The fix is is in the contact_overlay so this also affects emergency-dialer and the ice contacts. So, I’m checking to make sure it all works there. The only spot I found where it gets invoked is when the user goes to the ice contacts. This is in shared but there aren’t any other uses of this file other than emergency dialer and dialer.
- I have an NI to Ahmed for the following issue: in LTR, we have |+14085551212, Mobile|. When this gets wrapped in BDI, we have |+14085551212 ,Mobile| So the space is before the comma vs. after. I’m not sure if this is correct, so sent NI to figure out what we should do here. If the comma is supposed to have the space after, then probably an entirely different fix that what I have right now.
- As per my note in the bug, I’m just going to pull out the comma, make it a localizeable string in dialer to get this moving since it’s been six days since any response from the localization folks.
- bug 1011066 - Worked on this yesterday and spent quite a bit of time getting my multilocale build working. I did come up with a fix
- bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
that will take care of mirroring the SIM and the number. I took a screenshot and sent to Stephany for her to approve this approach.
- This was erroneously (I believe) marked as a regression. However, not sure who changes that flag. See Comment 13
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Landed. flagged with late-l10n keyword. Need to ask for uplift.
- Reviews:
- bug 1134871 - Finished this review - r+
- bug 1131261 - Finished this review - r+ with some minor comments.
- bug 1135023 - r?.
- New Bugs Filed
- bug 1134961 - Dialer suggestion is not bdi (the + is on the wrong side)
jlorenzo
- Admin:
- Will be on PTO next week from Tuesday 10th to Sunday 15th
- Done:
- Nothing to report today
- Next steps:
- Nothing currently planned for the dialer.
gsvelto
- Admin:
- None
- Bugs:
- bug 1131490 - [RTL][Dialer]The number of calls handled is shown at the right of call number.
- Landed on v2.2
- bug 1135023 - Recent contact's name disappears if you call him back with the call log
- A new patch is ready, consistently fixing the problems we saw in the bug
- Reviews
- None
ythej
- Admin:
- Set all ready for my GSoC project(Blacklist Implementation)
- Bugs:
// (I couldn’t work on more as I am working on project proposal and semester exams in my college)
- bug 1068224 - Limit the amount of calls shown in the call info view.
- Under r1?
- Need to write tests.
- bug 877307 - Add beep when dropped call - calceled or failed.
- Start working
- bug 1068224 - Limit the amount of calls shown in the call info view.