Firefox OS/Comms/Dialer/Sprint/v2.1-S7/20141021-StandupNotes
From MozillaWiki
< Firefox OS | Comms | Dialer | Sprint | v2.1-S7
Contents
Blockers
- 2.1+ bug 1081854 - GAIA follow-up to bug 978639 (for GCF case 31.4.2.1.3)
- Assigned to Tamara.
- Depends on bug 978639, which has landed. This is ready to go.
- 2.1+ bug 1079810 - Empty sound writes into speaker, cause serious power consumption
- Assigned to Doug.
- Dev Tools are holding a weak reference to the WebAudio context. Investigating more.
- 2.1- bug 1082876 - TypeError: context is null at: app://callscreen.gaiamobile.org/gaia_build_defer_index.js line: 84
- Assigned to Gabriele.
- In reality is basically a blocker, since it’s blocking a partner’s testing, even if there are no STR.
- Cause unknown, possibly something in shared/js/dialer/tone_player.js
- 2.1+ bug 1082139 - JavascriptException: JavascriptException: TypeError: window.getComputedStyle(...) is null at: app://callscreen.gaiamobile.org/gaia_build_defer_index.js line: 146
- Assigned to Germán.
- We are trying to reproduce the scenario mentioned by Anshul in Telefónica creating an integration test. I have not received the results from our QA team yet. Anyhow, I hope Anshul can provide us with further information about the tests he is running.
- It could be related to bug 548397 - window.getComputedStyle() returns null inside an iframe with display: none
- Germán has posted a patch for this. We don’t know if it fixes the issue or not.
- Anshul has confirmed the proposed patch solves the issue.
- Review requested from Tamara ;)
- 2.1+ bug 1075699 - Calling voicemail by long-pressing the 1 button displays an error and then calls
- Assigned to Tamara.
- Ready to land a fix, but waiting for vendor to reply to a needinfo.
- Moved to RIL component, but we should still watch this.
- We should land this as the vendor is unlikely to answer in time.
drs
- Admin:
- Nothing new.
- Next steps:
- MVC proposal.
- This is getting a lot further. I should have it ready in a few days. It has evolved in a “design guidelines” document that includes many things, including MVC, code styling, suggested refactors, etc.
- MVC proposal.
- Patches:
- bug 1079810 - Empty sound writes into speaker, cause serious power consumption
- Dev Tools are holding a weak reference to the WebAudio context. Investigating more.
- bug 1079810 - Empty sound writes into speaker, cause serious power consumption
- Reviews:
- bug 1069835 - [ partner confidential ]
- r-
- bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
- r-
- bug 1080771 - Remove phone number highlighting code
- r+
- bug 1081854 - GAIA follow-up to bug 978639 (for GCF case 31.4.2.1.3)
- f+
- bug 1069835 - [ partner confidential ]
- Other:
- In a discussion with a guy from Intel about the Telephony API.
gtorodelvalle
- Admin:
- Nothing to report.
- Next steps:
- bug 1082139 - JavascriptException: JavascriptException: TypeError: window.getComputedStyle(...) is null at: app://callscreen.gaiamobile.org/gaia_build_defer_index.js line: 146
- Blocker (2.1+) (see the blocker section)
- bug 977056: [Dialer] Visual discrepancies: Call ended view under conference call participants list
- I provided a sequence diagram including the observed event and data flow when in a conference call amongst 3 parties one of the remote ones leaves the conference call, using master (Gecko-63faaa5.Gaia-9e8e3bb). The source code is also available and you can paste it in http://bramp.github.io/js-sequence-diagrams/ to get it depicted and also to edit it.
- I really think it would be great to have this kind of diagrams for all the available calling scenarios and that they should be published in https://developer.mozilla.org/en-US/docs/Web/API/Telephony
- Definitely an interesting topic for our next ‘office hour’ and/or ‘bug bash’ session.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Helping Paco with this bug.
- We already have a new version of the patch covering the CDMA case (disabling the put-on-hold button) waiting for Carrie’s confirmation that that is the way to go.
- bug 1082139 - JavascriptException: JavascriptException: TypeError: window.getComputedStyle(...) is null at: app://callscreen.gaiamobile.org/gaia_build_defer_index.js line: 146
thills
- bug 1075699 - T-Mobile Voicemail Bug. Still no reply from partner. Francisco is going to help with this.
- bug 1079143 - BlueTooth Bug - Posted my findings on this. Still have an NI on me for this, but prioritizing this after the blocker
- bug 1068093 - Removed legacy call screen transitions - Need to make the changes based on latest review from drs.
- bug 1081854 - I posted a feedback for this yesterday and am currently working on tests. Running into some problems with the promises and spies so might need some help.
- bug 1082193 - Review for German. I’ve reviewed the code, checked out the branch and tested. Found one nit, but wanted to have an IRC with drs on whether we need a test for this.
- bug 1083402 - “X has left the call does not show up”. Etienne and Carrie confirm this is a regression. Do we need to prioritize this?
jlorenzo
- Admin: v188 is out: https://drive.google.com/open?id=0B7_yuXt7x6y4UERlZmxMV3VBNkE&authuser=0
- bug 1083731: pending feedback from QA in the US to run the test with AT&T and T-Mobile.
- bug 1086269: pending review
- bug 1086676: Add a test to check notification when you miss a call from a known contact.
Manual test run status for Dialer: Total: 348 => http://mzl.la/fxos-dialer-2-1-moztrap-active-test-cases Passed: 336 Failed: 8 => http://mzl.la/fxos-dialer-2-1-moztrap-test-run-3-non-passed Invalidated: 1 => http://mzl.la/fxos-dialer-2-1-moztrap-test-run-3-non-passed Not done: 1 => https://moztrap.mozilla.org/manage/case/13733/