Firefox OS/Comms/Dialer/Sprint/v2.1-S6/20141006-StandupNotes
From MozillaWiki
< Firefox OS | Comms | Dialer | Sprint | v2.1-S6
Blockers
- 2.1+ bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- Assigned to Doug. Kyle M (:qDot) is looking into the platform side. He says he found a fix (see bug 1076597), but there's a new IDB error, and we need Ben Turner for that (who is on vacation).
- I'm going to try fixing this by ensuring that there are no stale callscreen app instances in the main process. Kyle H suggested a method to do this.
- The patch in bug 1076597 may fix this.
- 2.1+ bug 1074379 - Dialer does not always show incoming call #
- Assigned to Anthony.
- This appears to be related to bug 1070066.
- The patch in bug 1076597 may fix this.
- 2.1+ bug 1068109 - Restore 2s delay before callscreen is closed
- Assigned to Tamara. Recently got blocker status.
- Ready to land.
- 2.1+ bug 1075699 - Calling voicemail by long-pressing the 1 button displays an error and then calls
- Assigned to Tamara. Can only be repro'd on a T-Mobile SIM.
- 2.0+ bug 1074601 - The SIM 2 Voice mail displayed as a "Unknown contact" in dialer view and call log view
- Assigned to Tzu-Lin, being reviewed by Doug. This is under control.
- 2.0? bug 1066874 - [Dialer] User can be put into a state where there is no one on the other line in a phone call and user is unable to end call
- Unassigned, new nom. Looks like it could be bad, and is not a regression.
- 2.0? bug 1077392 - The USSD interface shows "Session expired" when is sent a wrong USSD code.
- Unassigned, new nom.
- 2.0? bug 1078222 - USSD Notify response is not shown while USSD Request is working fine
- Unassigned, new nom.
drs
- Admin:
- We are beginning to really fall behind on blockers. We must redouble our efforts to get everything done by Friday.
- We also have the additional objective of completing our sprint bugs by the end of the week, which is looking unlikely to happen now.
- Next steps:
- bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- I will take a stab at fixing this within Gaia. I'm not sure how likely it is for us to get a fix from Kyle before Friday.
- bug 1066874 - [Dialer] User can be put into a state where there is no one on the other line in a phone call and user is unable to end call
- I will likely take this and investigate.
- bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
- My patches:
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- Landed.
- bug 1076231 - [SimPicker] fix racy unit tests
- Landed.
- bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
- Reviews:
- bug 1061398 - Incall keypad layout needs adjustment
- r+, landed
- bug 1062799 - Call information is not updated on the fly after creating a contact
- r-
- bug 831974 - [B2G][Dialer] User has to press 1 for a long time before Voicemail is reached
- r-
- bug 1068109 - Restore 2s delay before callscreen is closed
- r+, ready to land
- bug 1011272 - [B2G][RTL][Dialer] Arabic: "Call Log" in "Dialer" app has multiple issues.
- r?
- bug 1074601 - The SIM 2 Voice mail displayed as a "Unknown contact" in dialer view and call log view
- r?
- bug 1060293 - Remove dialer's buttons.css and use styling from shared/styles/buttons.css instead
- f?
- bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list
- r?
- bug 1061398 - Incall keypad layout needs adjustment
- Other:
- bug 1067883 - [ partner confidential ]
- Provided info, split this off into other bugs.
- bug 1077073 - Display an error when putting a call on hold fails
- bug 1077075 - Augment telephony API to notify client code of errors when attempting hold(), resume(), etc.
- Provided info, split this off into other bugs.
- bug 1075726 - Calling voicemail by long-pressing the 1 button (and then hanging up) leaves the dialer with "123" pre-entered (and possibly with a contact preselected for autodialing)
- Was able to repro this after setting the voicemail number to "123".
- bug 1067883 - [ partner confidential ]
Rik
- bug 1074379 Not much I can do here apart from asking QA to test with a potential mozSettings patch
- bug 1069286 Trying to write tests for this. I'll land without the new tests and open a follow-up.
- bug 1062799 Gave some input on how to fix it
- Reviews
gtorodelvalle
- Admin:
- Nothing to report.
- Bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
- Fixed the issues which was causing my previously proposed patch to fail. It was working originally as demoed in the video attached to the bug :(
- Just asked Doug (since he is leading the MVC task :p) for review. The reason is that this bug and the proposed patch is highly dependant and based on our current code base (HTML structure, the way we currently deal with events, nodes, etc.) so I can discuss with him if it is really worth it to keep it as proposed (and wait for the forthcoming MVC refactoring) or to go for deeper changes on our code base to solve the bug.