Firefox OS/Comms/Dialer/Sprint/v2.1-S6/20141002-StandupNotes

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint‎ | v2.1-S6
Jump to: navigation, search

Blockers

  • 2.1+ bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
    • Assigned to Tamara. Kyle (:qDot) is looking into the platform side. He says he found a fix (see bug 1076597), but there's a new IDB error, and we need Ben Turner for that (who is on vacation). For the time being, we're letting bug 1068109 fix this.
  • 2.2? bug 1074379 - Dialer does not always show incoming call #
    • Assigned to Anthony, but we should all try to repro this. This is pretty bad and we should fix it ASAP. There's no clear STR or even any suspected causes, so please help with that if you can.
    • This appears to be related to bug 1070066.
  • 2.0+ bug 1074601 - The SIM 2 Voice mail displayed as a "Unknown contact" in dialer view and call log view
    • Assigned to Tzu-Lin, being reviewed by Doug. This is under control.

drs

  • Admin:
  • Next steps:
    • Write MVC proposal.
      • I wanted to do this yesterday, but I got sidetracked by tons of reviews and my patches.
    • bug 1067883 - [ partner confidential ]
      • I got asked for help here, will need to provide info on how to do something and probably provide a patch.
      • <Rik> Is it possible to open a public bug?
      • I just got ni'd on it this morning, I'll always ask for that if I can.
  • My Patches:
    • bug 1060451 - Refactor copied-and-pasted displayMessage() code in emergency-call/dialer.js taken from dialer/telephony_helper.js
      • Posted a new iteration of this patch for Anthony and Francisco to review.
    • bug 1037354 - Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields
      • Waiting for Etienne to review this. Not sure where he is, so I might punt this to Gabriele.
    • bug 1076231 - [SimPicker] fix racy unit tests
      • r- for Julien.
      • I took this myself because he's on PTO and put up a new patch.
    • bug 1045820 - Port SimPicker implementation in MSAB and comms apps to GaiaSimPicker
      • (no changes today) Waiting for Anthony, Francisco to review.
  • Reviews:
    • bug 1074601 - The SIM 2 Voice mail displayed as a "Unknown contact" in dialer view and call log view
      • cleared r? Anthony did a drive-by f- on this so I'm not going to review it until those comments are addressed.
    • bug 1062799 - Call information is not updated on the fly after creating a contact
      • r-. New patch up that I need to review today.
    • bug 1061398 - Incall keypad layout needs adjustment
      • r+
    • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
      • r-
    • bug 1068109 - Restore 2s delay before callscreen is closed
      • r+
      • I'm not happy with the fix here being used as the fix for bug 1070066. I talked with qDot a bit yesterday. He's actually still around and said he will be until this is fixed. He says he found a fix (see bug 1076597), but there's a new IDB error, and we need Ben Turner for that (who is on vacation).
    • bug 1074224 - [Accessibility] Get rid of [role="button"] in CSS everywhere.
      • r+
    • bug 831974 - [B2G][Dialer] User has to press 1 for a long time before Voicemail is reached
      • r+
      • This isn't landable yet as it needs Carrie's input. I'm generally not happy with the solution here, but I don't mind doing more work on it in the future.
  • Other:
    • Triaged some bugs filed by dholbert.
    • Triaged some mentored bugs as they were stale with assignees who did nothing with them or they were for issues that didn't exist anymore.
    • Wrote office hour summary.
    • Cleaned up wiki a bit.
      • Added mentored bugs section.
      • Added office hour explanation and summary for this last one.
    • bug 1069499 - [Dialer] [User Story] It should be possible to easily delete single entry from the call log list
      • Helped via PM with setting up the simulator, testing changes, and answering questions about our code.

Rik

  • Admin
    • Will be on PTO tomorrow afternoon
  • Posted two patches for bug 831974 User has to press 1 for a long time before Voicemail is reached
  • Tried to get some help on bug 1069286, I'll post a WIP patch to get more help
  • Got a lot of needinfos/reviews, need to take a look at them
  • Received a thank you note from the graphics team on how we handled bug 1070993
  • Reviews

gtorodelvalle

  • Administrative:
    • Jorge has been requested by our Push team to start collaborating with them. Anyhow, he will finish the Comms bugs he is currently working on.
    • I have a meeting now at 16:00. Hopefully I will be out before 16:30, but just in case I am not able to join you guys today.
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Really weird stuff (sometimes it connects, sometimes it does not, etc.) going on connecting the BT headset to the device and managing calls. I have never used one of this BT devices before and it is not of my own so maybe that is the reason of the weird behaviour I observed.
    • We have included additional changes into the patch and a new review has been requested from Anthony.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • I am trying to get a detailed picture of the way we currently manage call changes events in the Call Screen app since it is kind of scattered among many areas and some times the observed results are not the desired ones such as the one mentioned in https://bugzilla.mozilla.org/show_bug.cgi?id=977056#c26
    • This is probably a good input for Doug's MVC proposal to try to clean things up :)
    • I'll keep you posted.
    • <drs> Thanks, will take this into account.

thills

  • bug 1024341 - Wakeup the device after call hangs up
    • We split this into several bugs. Right now, I'm working on one of the child bugs of this.
  • bug 1068109 to restore the 2s delay before the call screen goes away.
    • New patch for review with fix for contact image. I incorporated drs latest comments and then my PR got closed and I was asked to rebase and open a new one. I've done that and now just retesting and waiting for try to finish.
  • bug 1070066 - [Dialer] The call screen does not display call info and shows a black background after repeatedly placing calls
    • We talked about this and decided to let 1068109 fix this temporarily and then document that settings team will have a patch for this for a new API.
  • bug 1068093 - Remove legacy transition code from the callscreen
    • Started looking at this with 1068109 applied.
  • bug 1074379 - I spent some time trying to repro this yesterday and was able to after many successive calls. Updated the bug with my findings of where i saw errors.

pacorampas

  • Absent/no report

jpruden92

  • Absent/no report
Retrieved from "https://wiki.mozilla.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S6/20141002-StandupNotes&oldid=1052167"