Firefox OS/Comms/Dialer/Sprint/v2.1-S2

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Jump to: navigation, search

Contents

Postmortem

  • Planned velocity start: 41
  • Planned velocity end: 22
  • Planned velocity burndown: 19
  • Unplanned bugs: 7
  • Blockers: 0

Bugs

Status

Dialer v2.1-S2 burndown chart.png

  • 41,37,35,34,31,31,29,26,25,0

Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ No cf_feature-b2g [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- No cf_feature-b2g [planned-sprint] VERIFIED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- No cf_feature-b2g [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- No cf_feature-b2g [planned-sprint c=1] RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- No cf_feature-b2g [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- No cf_feature-b2g [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- No cf_feature-b2g [planned-sprint] RESOLVED DUPLICATE
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- No cf_feature-b2g [planned-sprint c=1] RESOLVED FIXED

9 Total; 0 Open (0%); 8 Resolved (88.89%); 1 Verified (11.11%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1026692 Tamara Hills [:thills] Access to mute button --- No cf_feature-b2g [tako][planned-sprint c=6][2.1-feature-qa+][in-sprint=v2.1-S2] VERIFIED FIXED
1038701 Doug Sherk (:drs) (inactive) [US] Support for ICE Contacts in Lockscreen/Emergency call --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] VERIFIED FIXED
1045499 Doug Sherk (:drs) (inactive) Switch call log to a 2-line layout --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] RESOLVED FIXED
1047353 Anthony Ricaud (:rik) Create a call information page for call log --- No cf_feature-b2g [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1047356 Anthony Ricaud (:rik) Modify the call log user interface to link to the call information page --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S2] RESOLVED FIXED

5 Total; 0 Open (0%); 3 Resolved (60%); 2 Verified (40%);

Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1030430 Yura Zenevich [:yzen] (please use "needinfo") Call log items should be listbox options --- No cf_feature-b2g [b2ga11y p=1] RESOLVED FIXED
1030431 Yura Zenevich [:yzen] (please use "needinfo") When in incoming call screen the SR can land on select audio channel element that should be invisible. --- No cf_feature-b2g [b2ga11y p=1][good first bug] RESOLVED FIXED
1030434 Yura Zenevich [:yzen] (please use "needinfo") Add a proper description for the call screen dialog. --- No cf_feature-b2g [b2ga11y p=1] RESOLVED FIXED
1047275 Tzu-Lin Huang [:dwi2][:tzhuang] Test ellipsis side on RTL pages for FontSizeManager --- No cf_feature-b2g RESOLVED FIXED
1050144 Jorge Prudencio [:jorgep] [Dialer] "Call ended" text not vertically centred --- No cf_feature-b2g RESOLVED FIXED
1050390 Yura Zenevich [:yzen] (please use "needinfo") Fix visibility issues around hidden elements within the callscreen dialog. --- No cf_feature-b2g RESOLVED FIXED
1051841 Gabriele Svelto [:gsvelto] [dolphin] There's no title (sim index and operator name) on USSD message received --- No cf_feature-b2g RESOLVED FIXED
1052370 Jorge Prudencio [:jorgep] [Dialer][Emergency call] Duplicate phone number when typing number --- No cf_feature-b2g RESOLVED FIXED

8 Total; 0 Open (0%); 8 Resolved (100%); 0 Verified (0%);

All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ --- [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- --- [planned-sprint] VERIFIED FIXED
1030430 Yura Zenevich [:yzen] (please use "needinfo") Call log items should be listbox options --- --- [b2ga11y p=1] RESOLVED FIXED
1030431 Yura Zenevich [:yzen] (please use "needinfo") When in incoming call screen the SR can land on select audio channel element that should be invisible. --- --- [b2ga11y p=1][good first bug] RESOLVED FIXED
1030434 Yura Zenevich [:yzen] (please use "needinfo") Add a proper description for the call screen dialog. --- --- [b2ga11y p=1] RESOLVED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- --- [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- 2.1 [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- --- [planned-sprint c=1] RESOLVED FIXED
1047275 Tzu-Lin Huang [:dwi2][:tzhuang] Test ellipsis side on RTL pages for FontSizeManager --- --- RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- 2.1 [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- --- [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- --- [planned-sprint] RESOLVED DUPLICATE
1050144 Jorge Prudencio [:jorgep] [Dialer] "Call ended" text not vertically centred --- --- RESOLVED FIXED
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- --- [planned-sprint c=1] RESOLVED FIXED
1050390 Yura Zenevich [:yzen] (please use "needinfo") Fix visibility issues around hidden elements within the callscreen dialog. --- --- RESOLVED FIXED
1051841 Gabriele Svelto [:gsvelto] [dolphin] There's no title (sim index and operator name) on USSD message received --- --- RESOLVED FIXED
1052370 Jorge Prudencio [:jorgep] [Dialer][Emergency call] Duplicate phone number when typing number --- --- RESOLVED FIXED

17 Total; 0 Open (0%); 16 Resolved (94.12%); 1 Verified (5.88%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
982163 Doug Sherk (:drs) (inactive) Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call() 2.0M+ --- [planned-sprint] RESOLVED FIXED
991573 David Garcia [:davidg][retired] Change success message for Call Barring and Call Waiting interrogation through MMI --- --- [planned-sprint] VERIFIED FIXED
1039643 Tamara Hills [:thills] Write some unit tests for shared/js/dialer/contacts.js --- --- [planned-sprint c=][in-sprint=v2.1-S1] RESOLVED FIXED
1043133 Jorge Prudencio [:jorgep] [Dialer] Call with new taller hang up button --- 2.1 [planned-sprint c=1][good first bug] RESOLVED INVALID
1045515 David Garcia [:davidg][retired] Always highlight missed calls in call log --- --- [planned-sprint c=1] RESOLVED FIXED
1047351 Anthony Ricaud (:rik) Insert call durations in the call log database --- 2.1 [planned-sprint c=3] RESOLVED FIXED
1047642 Device stuck in the dialer screen --- --- [caf priority: p3][CR 703272][planned-sprint] RESOLVED WORKSFORME
1048285 [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call --- --- [planned-sprint] RESOLVED DUPLICATE
1050196 Germán Toro del Valle (:gtorodelvalle) [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call --- --- [planned-sprint c=1] RESOLVED FIXED

9 Total; 0 Open (0%); 8 Resolved (88.89%); 1 Verified (11.11%);


Daily Standup Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: August 18

drs

  • Admin:
    • I did some pre-sprint planning.
  • Next steps:
    • bug 1047275 - Test ellipsis side on RTL pages for FontSizeManager
      • Review+ for Tzu-Lin.
  • Done:
    • Did some work outside the dialer.
    • bug 1045499 - Switch call log to a 2-line layout
      • Put up a new patch with UI changes requested by Carol.
      • Waiting for review from Anthony.

thills

  • bug 1026692 - Access to mute button
    • Need feedback/review on the latest submission. Need help for the height issue and a way to avoid the inline styling without breaking the keypad layout in the dialer.

jpruden92

  • Introducing on unit tests.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Fixed.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • ui-review done.
  • bug 1052370 - [Dialer][Emergency call] Duplicate phone number when typing number:
    • Fixed

Rik

  • Absent/no report

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

Day 9: August 15

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1047275 - Test ellipsis side on RTL pages for FontSizeManager
      • Review- for Tzu-Lin. New version is up which I have to review.
    • This is all my work for this sprint, so I'll likely take other people's bugs at this point, or work on Gecko stuff.
  • Done:
    • bug 1045499 - Switch call log to a 2-line layout
      • Put up a patch, waiting for review from Anthony.
    • bug 1047351 - Insert call durations in the call log database
      • Review+ for Anthony. Landed.

thills

  • bug 1026692 - Access to mute button
    • Still working on the new button approach with the pseudo element trying to get it right.
    • Continuing to work on CSS for the height issue.

Rik

  • Holiday in France
  • May be around to review bug 1045499.

gtorodelvalle

  • Holiday in Spain

pacorampas

  • Holiday in Spain

jpruden92

  • Holiday in Spain

Day 8: August 14

drs

  • Admin:
    • There's not a lot of demos posted on the sprint demo page.
    • bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
      • The QA contact was changed. As discussed, it would be best if Loli was QA on this so that her and Germán can talk about it.
      • <gtorodelvalle> It seems Jorge Lorenzo will be the QA contact verifying the whole life cycle of the ICE contacts feature so we should be fine. No way to test our part until the Contacts and Settings apps are available.
  • Next steps:
    • bug 1047351 - Insert call durations in the call log database
      • Review- for Anthony. New version is up which I have to review.
    • bug 1047275 - Test ellipsis side on RTL pages for FontSizeManager
      • Review- for Tzu-Lin. New version is up which I have to review.
    • bug 1045499 - Switch call log to a 2-line layout
      • Will have a patch today.
  • Done:
    • bug 1037868 - Create gaia-sim-picker component
      • Put up a patch for review for Kevin and Anthony. This is actually ready to go now and got r+ already from Kevin. Now Anthony has to review it.
      • Should we move this to Etienne for review?
      • <Rik> I've delayed this one a lot because I'll need to learn about web components and it is not critical. I think I'll delay it till FL.
      • Yeah, I figured, but Etienne may not have a lot to do. Maybe we should ask him and then decide? -> Yup
      • And btw, I agree with not prioritizing it. You still have a lot to do.
    • bug 1030430 - Call log items should be listbox options
      • Review+ for Yura.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Landed.
      • <Rik> I'm really happy that we managed to fix the platform. Good job!
      • Me too. Too many workarounds.

Rik

  • Admin: Friday is a holiday for France and Spain
  • Addressed review comments on bug 1047351 Insert call durations in the call log database. Ready to land.
  • Commented on next steps for bug 911055.
  • Helped Tamara on bug 1026692
  • bug 1035763 - support 24 hour time format - is now ready for next sprint
  • Made progress on bug 1047356. I hoped to have a patch yesterday but lots of renaming happened and so it's cumbersome to change everything. Really close now.
  • Reviews

gtorodelvalle

  • Administrative:
    • Finally I will be on PTO since tomorrow till next Wednesday :O Since I start the summer holidays on the 27th, I will have 5 available days for next sprint. As you know, Telefonica is very interested in working on bug 889737 although I agree with Anthony regarding the fact that although we can start implementing the Gaia part, it is highly dependant on the Gecko one (event notification and so on). Not to mention the possible regressions to arise. So, sincerely I think the Gaia part should be postponed until the Gecko one is available.
    • Anyhow, feel free to assign to me the bugs you consider appropriate for the next sprint planning taking into consideration my availability :)
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Mentoring Jorge working on this bug. I think it is worth it the time spent on this;)
  • bug 1050162 - [LockScreen] No SIM label when there is an incoming call:
    • As suggested by Anthony, it finally is a regression of bug 1018283 combined with bug 1033585. I will comment on this on the bug to decide how to proceed.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Reviewed and ready to land.
    • Review from Anthony requested.
    • r+ by Anthony.
    • I'll ask Jorge to land it in master tomorrow.
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • Started working on this bug.
    • Included questions for Carrie and Carol in the bug.
    • Icon missing and some minor suggestions included in the bug.
    • Demo of the current implementation at http://youtu.be/0q0rkp8T4-s
    • I will ask for review from Anthony before EOB.
    • Loli and myself set as CC in the ICE contacts related bugs for the Contacts and Settings apps to monitor their progress so she can test and verify the whole life cycle.
    • <drs> See my admin update.
    • <gtorodelvalle> Ups, first notice :) Let's see who she/he is. I'll ask Jorge Lorenzo if he has any interest on verifying this bug.
    • <gtorodelvalle> OK, it seems he already is the QA contact for the other related bugs so we should be good here. Anyhow, I'll check with him
    • <drs> Thanks, let us know if there are any problems.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm wontking with German on Tests. I have some doubts about the tests, therefore they aren't working fine. I have sent the brach to German to ask him some questions (more questions).
    • Only the tests are failing, but the patch is working on phone.
  • bug 1035153 - Prototype Dialer without tab bar
    • I am adding the changes that carrie asked for
      • <drs> You said before that you're going on PTO and won't have time to finish this. Do you have an update on this? We can get someone else to finish it up once you leave.
      • I have updated on bug the patch with the new changes. You can follow it, but the two main changes are done.
      • <drs> Okay, thanks!
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
    • Waiting for decision of UX, We are waiting for NI of pabratowski@mozilla.com and kyee@mozilla.com
    • I am on PTO until August 25th.

thills

  • bug 1026692 - Access to mute button
    • Continuing to work on CSS for buttons with new sprite approach (don't need new assets from Carol)
    • Continuing to work on CSS for the height issue.

jpruden92

  • <drs> Please set the ASSIGNED status and target milestone field when you begin working on something. Thanks.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Waiting to Pull Request Acepted.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Waiting to ui-review.
  • bug 1052370 - [Dialer][Emergency call] Duplicate phone number when typing number:
    • Patch developed. Waiting to Pull Request Acepted.

// Part-time people (not required to update this)

Day 7: August 13

drs

  • Admin:
    • I wrote up a report that I sent out in an email about my meeting with relman.
  • Next steps:
    • bug 1045499 - Switch call log to a 2-line layout
      • In progress.
    • bug 1047275 - Test ellipsis side on RTL pages for FontSizeManager
      • Review- for Tzu-Lin. Another version is up for review already which I'll get to soon.
    • bug 1030430 - Call log items should be listbox options
      • Need to review this for Yura.
  • Done:
    • bug 1047351 - Insert call durations in the call log database
      • Review- for Anthony. Pretty nit-picky problems; should be easy to fix.
    • bug 1037868 - Create gaia-sim-picker component
      • Put up a patch for review for Kevin and Anthony. This is actually ready to go now and got r+ already from Kevin. Now Anthony has to review it.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Put up a patch for review from Kats. This has moved into APZ/Gonk as a result of Botond's helpful investigation.

Rik

gtorodelvalle

  • Administrative:
    • I talked to Kevin Grandon regarding his email with subject "FxOS Gaia Weekly /w Tech Talk" about giving a talk about integration tests I already gave internally at Telefónica :) and as a result of that conversation he mentioned the possibility of giving talks about the architecture of applications or more specifically about the separation of the Comms apps into independent apps. Just in case anyone wants to consider it :)
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Mentoring Jorge working on this bug. I think it is worth it the time spent on this;)
  • bug 1050162 - [LockScreen] No SIM label when there is an incoming call:
    • As suggested by Anthony, it finally is a regression of bug 1018283 combined with bug 1033585. I will comment on this on the bug to decide how to proceed.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Reviewed and ready to land.
    • Review from Anthony requested.
    • r+ by Anthony.
    • I'll ask Jorge to land it in master tomorrow.
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • Started working on this bug.
    • Included questions for Carrie and Carol in the bug.
    • Icon missing and some minor suggestions included in the bug.
    • Demo of the current implementation at http://youtu.be/0q0rkp8T4-s

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Adding tests
  • bug 1035153 - Prototype Dialer without tab bar
    • I am adding the changes that carrie asked for
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
    • Waiting for decision of UX

thills

  • bug 1026692 - Access to mute button
    • Received some feedback from Carol with third button state for the mute. This also fixes the problem of the white on grey being difficult to see. We need her to update the asset so shifting the sprites is easier
    • Incorporating Rik's feedback from latest.
    • Currently trying to get the height layouts correct without breaking other parts of the keypad.

jpruden92

  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • Bug marked as "RESOLVED INVALID". Changes won't be applied.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Waiting to Pull Request Acepted
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Developing a patch.
  • bug 1052370 - [Dialer][Emergency call] Duplicate phone number when typing number:
    • Patch developed. Waiting to Pull Request.

// Part-time people (not required to update this)

Day 6: August 12

drs

  • Admin:
    • I'm back from PTO.
    • I'm going to write up more details from the meeting between Lawrence and I about relman.
  • Next steps:
    • bug 1047351 - Insert call durations in the call log database
      • Need to review this for Anthony. I took a quick look at it before I left.
    • bug 1047275 - Test ellipsis side on RTL pages for FontSizeManager
      • Need to review this for Tzu-Lin.
    • bug 1045499 - Switch call log to a 2-line layout
      • Going to work on this, ideally get a patch up today.
    • bug 1037868 - Create gaia-sim-picker component
      • Optional. Going to work on this if I have time.

Rik

  • I changed strategy on bug 1047353. Instead of creating the page, I'll modify the call log to link to it first (bug 1047356). It was annoying for development to not have this. I get to do a lot of cleanup by modifying this overlay.
  • Started a discussion with our design team about bug 945225 don't stretch low-res profile pictures. I was concerned about the code and user complexity this would introduce. We should wait before implementing this.
  • Reviews

gtorodelvalle

  • Administrative:
    • I talked to Kevin Grandon regarding his email with subject "FxOS Gaia Weekly /w Tech Talk" about giving a talk about integration tests I already gave internally at Telefónica :) and as a result of that conversation he mentioned the possibility of giving talks about the architecture of applications or more specifically about the separation of the Comms apps into independent apps. Just in case anyone wants to consider it :)
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Mentoring Jorge working on this bug. I think it is worth it the time spent on this;)
  • bug 1050196 - [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call:
    • Landed in master.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • Patch implementing the agreed combined approach available.
    • Review requested from Anthony. r+ :)
    • Landed in master.
  • bug 1050162 - [LockScreen] No SIM label when there is an incoming call:
    • As suggested by Anthony, it finally is a regression of bug 1018283 combined with bug 1033585. I will comment on this on the bug to decide how to proceed.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Reviewed and ready to land.
    • Review from Anthony requested.
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • Started working on this bug.
    • Included questions for Carrie and Carol in the bug.

thills

  • bug 1026692 - Access to mute button
    • I have a WIP version for feedback from rik that has the functionality implemented.
    • I have a couple of questions around the approach and that would determine the testing direction.
    • I do think that the choice of white on light grey is very difficult to see... so we should consider asking for UX feedback on this.
    • I need to start looking for a gecko bug to work on in parallel.

jpruden92

  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • Bug marked as "RESOLVED INVALID". Changes won't be applied.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Waiting to Pull Request Acepted
  • bug 943389 - [Dialer] "Call ended" text not vertically centred:
    • Developing a patch.
  • bug 1052370 - [Dialer][Emergency call] Duplicate phone number when typing number:
    • Starting with this bug.

// Part-time people (not required to update this)

pacorampas

  • Absent/no report

Day 5: August 11

drs

  • On PTO

Rik

  • Admin: When generating the burndown chart, add the sequence of points so that the next host can use them
  • Started looking how to share code with Contacts for the call information page
  • Reviews

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Mentoring Jorge working on this bug. I think it is worth it the time spent on this;)
  • bug 1050196 - [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call:
    • Patch available.
    • review+ by Anthony. I will land it after the daily meeting.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • I proposed and checked a modified version based on Anthony's comments and it works.
    • Waiting for a decision on the final approach to follow :)
    • I will push the agreed code to Github after the daily meeting and wait for the tests to pass before merging.
  • bug 1050162 - [LockScreen] No SIM label when there is an incoming call:
    • As suggested by Anthony, it finally is a regression of bug 1018283 combined with bug 1033585. I will comment on this on the bug to decide how to proceed.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Adding tests
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
    • Waiting for decision of UX

thills

  • bug 1026692 - Give access to the mute button while in call and on the dialpad.
    • I received feedback from rik on this (Thank you) and incorporated most of it into the code.
    • We received sprites from Carol so now working on moving the sprite when the user hits the mute button.
    • I hooked up the mute functionality to the new button and made it keep state with the mute button on the main in call screen.

jpruden92

  • Absent/no report

Day 4: August 8

drs

  • Admin:
    • I'm on PTO on Friday (tomorrow) and Monday.
    • I had a great long meeting with Lawrence (lmandel) where we talked about relman's handling of releases. You can see our notes here: https://etherpad.mozilla.org/relman-information I'll explain more when I get back.
  • Next steps:
    • bug 1045499 - Switch call log to a 2-line layout
      • Checked that we have everything we need to do this.
      • Working on this when I come back.
    • bug 1047351 - Insert call durations in the call log database
      • I started reviewing this, but couldn't finish in time. Will do it next week.
  • Done:
    • bug 1037868 - Create gaia-sim-picker component
      • Wrote up a small test case, only took a few minutes. Kevin is going to investigate while I'm on PTO.
    • bug 1045515 - Always highlight missed calls in call log
      • Review+ for David.

Rik

  • Was not feeling well so slower than usual
  • Worked on other stuff (presentation)
  • Feedback/help on bug 911055 [Dialer]DuT doesn allow to dial a <<pause>>
  • Reviewed bug 1050723

gtorodelvalle

  • Administrative:
    • Sadly I won't be able to join the daily meeting :(
    • Jorge already has permission to work with bugs in Bugzilla normally \o/
  • bug 1049426 - [Flame] Screen is shifted some pixels up:
    • I helped Jorge to take a look at it.
    • It seems it does not reproduce any longer :)
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Mentoring Jorge working on this bug.
  • bug 1050196 - [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call:
    • Patch available.
    • Asked Anthony for review.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • I proposed and checked a modified version based on Anthony's comments and it works.
    • Waiting for a decision on the final approach to follow :)

thills

  • bug 1026692 - I put a WIP version for feedback. I have an issue with some extra padding that I need to modify that might affect other screens so I need some feedback on this. Trying to work on wiring the mute button to the correct functionality now.

jpruden92

  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • Patch created. Waiting to Carol's response.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Patch created. Waiting to Carol's response.

pacorampas

  • Absent/no report

Day 3: August 7

drs

  • Admin:
    • I'm on PTO on Friday (tomorrow) and Monday.
  • Next steps:
    • bug 1047353 - Create a call information page for call log
      • Just started. Maybe reassign to Anthony?
    • bug 1045499 - Switch call log to a 2-line layout
      • Next bug after 1047353.
    • bug 1047351 - Insert call durations in the call log database
      • Need to review this for Anthony.
    • bug 1045515 - Always highlight missed calls in call log
      • Review- for David. Need to review the next iteration.
  • Done:
    • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
      • Checked in.
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Review+ for David, checked in.
    • bug 1037868 - Create gaia-sim-picker component
      • Kevin is going to check this out, nothing for me to do here for now.

Rik

  • Abandoned blocker bug 1047642. I sent a mail to release management to explain that we want someone working on lower levels to work on this.
  • Submitted my patch for bug 1047351, the database part of the call duration feature
  • I don't have anything else for the sprint so I'll empty my needinfos/reviews and then look for something to tackle.
    • <drs> That was fast! Want to take one of mine?
    • I could take the call information page when you're on PTO?
    • <drs> Sure, I barely got started so it's probably best for you to just start over on it. I'll work on bug 1045499 instead.
  • Reviews

gtorodelvalle

  • Administrative:
    • I noticed that until yesterday we did not have any "good first bug"s in Dialer whereas there are many in other apps which ease the starting up of new people joining the group :) See bug 1043133 as an example. So, if you find a bug susceptible of being solved by a newcomer, please set the flag in "Whiteboard" ;)
    • Jorge (jpruden92@gmail.com) needs permissions "to modify" (to assign bugs to himself, etc.) bugs in Bugzilla. Any clue who I should contact? Mari Ángeles is on PTO :) He's using his Gmail account not the @telefonica.com one which I have been told that is assigned the corresponding permissions automatically.
      • <drs> I think I contacted dolske or gavin, I can't remember. Though they may be inappropriate choices since they're both Fx managers/devs.
      • <Rik>you can ask in #bmo I think
      • Will do ;) Thanks!
    • I created bug 1050196 as a follow up of bug 1024506 to cover an scenario I missed. How should I proceed about it since created during the sprint? Shall I include it and solve it during this sprint? :)
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Included additional questions for Carrie.
  • bug 1050196 - [Dialer] Follow up of bug 1024506 - Place new call button momentarily enabled while establishing a second call:
    • Bug found and created while helping Paco with bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • Mentoring Jorge on this bug.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • We created this bug so Jorge could work on it to continue familiarising with the code and the dev tools.

thills

  • bug 1039643 - Latest updates from Anthony's review are posted.
  • bug 1026692 - Some progress, though it looks like this is a redo of the sizing on all the

keypad elements. I've got the buttons added and am just working trying to get all the sizing elements adjusted properly.

jpruden92

  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • I'm waiting to Carol's response.

pacorampas

  • Absent/no report

Day 2: August 6

drs

  • Admin:
    • I wrote a burndown chart generator which you can find here: http://people.mozilla.org/~dsherk/burndown.html
    • I updated the instructions for hosting the standup. We no longer record meeting minutes from IRC, but we now update the burndown chart each day.
    • Unfortunately, it seems like we can't do CDMA work in NA. Vance has been helping us figure this out.
  • Next steps:
    • bug 1045515 - Always highlight missed calls in call log
      • Need to review this for David.
    • bug 1047353 - Create a call information page for call log
      • Top priority coming up. Going to start today.
    • bug 1045499 - Switch call log to a 2-line layout
      • Carrie has answered, but we still need UI work before this is doable.
  • Done:
    • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
      • Put up a patch for review from Anthony.
      • I had to iterate based on feedback from UX.
    • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
      • Review+ for David.
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Review- for David.
    • bug 1037868 - Create gaia-sim-picker component
      • I was almost ready to post this, so I went ahead and did it even though we have higher priorities. I needed Kevin's help with a couple of things, so once he takes a look, I probably won't come back to this for a bit.
    • Cleaned up sprint planning wiki for v2.1-S2.

Rik

gtorodelvalle

  • Administrative:
    • Although yesterday we decided to remove bug 977588 from the current spring and include bug 1044996. The point is that there are currently discussions going on in bug 1044996 which will postpone its implementation so we would suggest removing bug 1044996 and re-including bug 977588 in this spring. Paco has been and is currently working on it.
      • <drs> Ok, we can add this back in. This feels like one of those things where sprints and planning don't quite articulate the situation correctly.
      • <gtorodelvalle> I would also add as having some influence the shitty mic Paco seems to have at home :p
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • Implemented Anthony's suggestions.
    • New code review requested.
  • bug 1043133 - [Dialer] Call with new taller hang up button:
    • We used this bug, previously assigned to Paco, to mentor Jorge Prudencio (our new intern) to go through a bug life cycle (ui-review requests, pull request life cycle, etc.).
      • <drs> Sweet! Cool to see a new member. Will Jorge be working on the dialer?
      • <gtorodelvalle> Yeap, that's the idea. I will finally introduce him to you guys tomorrow :)
    • Feedback requested from Carol regarding the other scenarios where a hang up button is present.
    • Jorge's first patch ready waiting for the requested feedback \o/

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • Adding new button for merge calls
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
    • Waiting for decision of UX

thills

  • bug 1039643 - Latest updates from Anthony's review are posted.
  • bug 1026692 - Got my app-manager working and a better way to debug this and

see what's going on (Thanks for the advice). Now just looking for where I need to modify.

jpruden92

  • New team member to be on IRC tomorrow!

Day 1: August 5

drs

  • Admin:
    • Unfortunately, it seems like we can't do CDMA work in NA. Vance has been helping us figure this out.
    • Did some pre-sprint planning.
  • Next steps:
    • New bugs that we take in sprint planning.
    • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
      • Almost ready to go into review.
  • Done:
    • bug 1047224 - [Dialer] [Keypad] Follow up for 1043318
      • Review+ for Paco.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Wrote up a Gaia workaround for this and put it up for review from Anthony.
    • bug 991573 - Copy improvements in Call Barring service through MMI
      • Gabriele helped me review this and we went over some of the cases together and next steps.
    • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
      • Put up a patch for review from Anthony, asked for UX input. Might have to iterate on it.

gtorodelvalle

  • Administrative:
    • Nothing to report.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Patch ready.
    • ui-review+ by Carrie.
    • Carols asked for a minor change but bug 1048285 is blocking the testing of the new patch.
    • Code review pending :p
  • bug 1048285 - [Dialer][Call Waiting][Rocketbar] Wrong rocket bar height when trying to establish a second call:
    • Trying to figure out what's going on here since it is blocking the making of second calls, conference calls, etc.
    • Duplicate of bug 1047255.
  • bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
    • ui-review+ by Carol.
    • Code review pending :p
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Proposal made to Carrie and asked need-info to her regarding the final implementation.
    • Hopefully she agrees since we are following the proposed path ;)
    • New confirmation asked from Carrie.
    • Helping Paco with the patch.

pacorampas

  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
    • I'm working on some failures that German said me
    • Adding new button for merge calls
  • bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)

Rik

  • Absent/no report

thills

  • Absent/no report

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> Our situation is generally really stable and we kept it that way the whole sprint.
  • <drs> The "things we could do better" is massive but the reality is that we're actually fine. It's good that we're thinking about things we can improve, though.

Things we could do better

  • <drs> We were pretty lethargic about doing demos. Was there a communication problem here?
    • <Rik> For me, nothing to demo.
    • <drs> Does everyone think there's value in demos? We assumed that because the other teams do them, we should too, but if nobody sees any value then we don't have to do them.
    • <gtorodelvalle> In my case the limitation is due to bug 1048285 which is blocking the establishment of second and conference calls to record the demos :(
    • <thills> I don't see much value for something "non-functional" such as writing unit tests and showing a screenshot of the unit tests completed. I think there is lot of value when it's something user-facing and we can show it to UX team/product owners.
    • <drs> When we talked about this in one of our standups, we decided that user-facing features would be demoed, but you could also demo non-functional features if you want to. See https://wiki.mozilla.org/index.php?title=FirefoxOS/Comms/Dialer/Sprint/v2.1-S1/20140722-Minutes
    • <gtorodelvalle> Totally in favor of recording demos :)
  • <drs> If we had blockers come up during the sprint, we would have been in trouble. We just barely got everything we initially planned done. This is ok as we agreed that we might have to move some work out of the sprint in this case, but we were still a bit behind where I wanted to be.
  • <drs> Our estimates were generally too rosy. This is also totally fine since we knew our first few times would be used to improve later.
  • <drs> There was generally some mess-ups surrounding bug 1018283. We messed up by not splitting it up more, and relman messed up by not communicating more. We're taking steps to address this such as helping relman publish data that is useful to us.
  • <drs> Thoughts on the "Meeting Minutes" section on the wiki? Does anyone read this or can we stop putting it up?
  • <Rik> Giving some "from scratch" work to Tamara was probably not the best idea. It was on top of crappy code. Too many concepts to grab at once.
  • <Rik> I fell behind on review times and that probably slowed you down.
    • <drs> It did, but I'm not sure what we can do here. I think this problem will solve itself once we have more peers. You can redirect more to me sooner though. At this point, I don't think you should have to really think about what to send me. You can probably pick 50% of your reviews essentially at random and give them to me.
  • <gtorodelvalle> (please do not take this as a complaint at all :) ) I think it is hard (impossible I may say) for reviewers to know in advance how much time it will take to do the reviews and this sometimes delays the landing of bugs :)
  • <Rik> Maybe we should start doing a burndown chart to see the progress as we go (instead of "guessing" by looking at a table that is hard to "parse")

Action items

  • <drs> Stop recording meeting minutes and use http://logs.glob.uno/?c=mozilla%23fxos-dialer instead.
  • <drs> Do demos. Reviewers should remind people.
  • <drs> Do blog post(s) at the end of the sprint. Anthony will write it.
  • <gtorodelvalle> Reviewers should have enough headroom (not assigned points or whatever we may call it) to deal with reviews :)
  • <drs> Do burndown charts.

Demos

bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled.

  • Outgoing single call during establishment:

  • Before

  • After

  • Outgoing second call during establishment:

  • Before

  • After

bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call

  • No ICE contacts available (no visual change here but just to confirm it :) ):

  • Before

  • After

  • ICE contacts with at least one phone number available:
  • Feature no avaiable

    Before

  • After

  • 1 ICE contact with 1 stored phone number:
  • Feature no avaiable

    Before

  • After

  • 1 ICE contact with 3 stored phone numbers:
  • Feature no avaiable

    Before

  • After

  • 2 ICE contact with 3 and 5 stored phone numbers respectively:
  • Feature no avaiable

    Before

  • After

Retrieved from "https://wiki.mozilla.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S2&oldid=1052073"