TPE-Layout/2017-12-05

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

  • Online training course (e.g. English class) will need to pay extra 20% if it's no registration in Taiwan.
    • Reference: 法規資料
      • 十、 在中華民國境內無固定營業場所及營業代理人之營利事業,有前九款所列各類所得以外之所得,按給付額扣取百分之二十。
  • Firefox Data Collection
    • Process reference
      • Category 1 “Technical data
      • Category 2 “Interaction data
      • Category 3 “Web activity data
      • Category 4 “Highly sensitive data

Weekly Sharing

Weekly Status

Astley Chen

  • bug 1418470 Invalid bug or security bug
    • Bug 1418470 - triaged
  • bug 1407955 NEW:: Issues with text-shadow in SVG text (selected vs non-selected, fill vs stroke vs clipPath)
    • Bug 1407955 - investigating

Boris Chiou

  • Reviewed a Servo PR, #19470: style: Move mask-size outside of mako
  • bug 1421509 NEW:: Drop duplicated code from nsStyleTransformMatrix
    • Filed bug 1421509 - Drop duplicated code from nsStyleTransformMatrix
  • bug 1408303 ASSIGNED:: make FontFaceSet and FontFace use Servo for parsing font descriptors and properties
    • Cleaned up my code for bug 1408303
    • Wrote a patch for bug 1408303 - make FontFaceSet and FontFace use Servo for parsing font descriptors and properties
    • Wrote a patch to parse FontFaceSet by Servo backend for bug 1408303

Cameron McCormack

  • bug 1421368 NEW:: Document.elementsFromPoint should include SVG 'text' elements
    • Reviewed bug 1421368
  • bug 1422654 RESOLVED::FIXED stylo: Avoid restyling the element if it has bindings without stylesheets.
    • Reviewed bug 1422654
  • bug 1420741 RESOLVED::FIXED stylo: page takes 5 min to load
    • Reviewed bug 1420741
  • bug 1422676 RESOLVED::FIXED small error in test_2d.fill.pattern.imageSmoothingEnabled.html
    • Uploaded patch for bug 1422676
  • bug 1408303 ASSIGNED:: make FontFaceSet and FontFace use Servo for parsing font descriptors and properties
    • Reviewed bug 1408303 by the macro god
  • bug 1417837 NEW:: de-scope the style sheets in aboutReader.html
    • Submitted new patches for bug 1417837
  • bug 1422634 RESOLVED::FIXED Crash in mozilla::ServoStyleSet::SetStylistStyleSheetsDirty
    • Reviewed bug 1422634
  • bug 1265343 RESOLVED::FIXED stylo: Implement 'shape-image-threshold'
    • Reviewed bug 1265343
  • bug 1420762 RESOLVED::FIXED Make StyleSets get notified by the stylesheet directly, and not by the document.
    • Reviewed bug 1420762
  • bug 1420026 ASSIGNED:: replace one more use of nsCSSParser::ParseColor with ServoCSSParser::ComputeColor
    • Uploaded some more patches for bug 1420026
    • Working on fixing test failures in bug 1420026

CJ Ku

  • bug 1399787 NEW:: Create a new sandboxed process to run pdfium
    • Bug 1399787 update patches

Eric Tsai

  • Issue triage
  • Taiwan issue diagnosis/contact/close from SV friends

Jeremy Chen

  • bug 1376117 RESOLVED::DUPLICATE RestyleManager::mRestyleGeneration should be a uint64_t
    • Uploaded a patch to Bug 1376117
  • bug 1283222 ASSIGNED:: Unwanted line-break opportunities at out-of-flow frames [was: Commas wrapped to beginning of line with text-align: justify]
    • Read more text related codes for [Bug 1283222]
  • bug 1418433 RESOLVED::FIXED stylo: window.getComputedStyle(element, null) would not get correct data for display: none element
    • Added more tests and relanded Bug 1418433
    • Fixed an intermittent, get r+, pushed a try before re-landing [Bug 1418433]
    • Requested uplift Bug 1418433
  • bug 1421197 RESOLVED::FIXED use 64-bit for restyle generation counters to avoid overflow issues
    • Landed Bug 1421197
  • bug 1418472 NEW:: Wrong position of github issue name on hover
    • Investigated/replied NI/assigned to myself [Bug 1418472]

Louis Chang

Ting-Yu Lin

  • bug 1420026 ASSIGNED:: replace one more use of nsCSSParser::ParseColor with ServoCSSParser::ComputeColor
    • Reviewed bug 1420026.
  • bug 1265343 RESOLVED::FIXED stylo: Implement 'shape-image-threshold'
    • Landed bug 1265343.
    • Uploaded patches for bug 1265343.
  • bug 1422676 RESOLVED::FIXED small error in test_2d.fill.pattern.imageSmoothingEnabled.html
    • Reviewed bug 1422676.
  • bug 1418224 RESOLVED::FIXED stylo: support shape-outside: <image>
    • Landed bug 1418224.
  • bug 1421204 RESOLVED::WORKSFORME Incorrect layout
    • Triage bug 1421204.

Tommy Kuo

  • Austin Lightning Talk
    • Prepare the lightning talk for Austin All Hands
    • Prepare the lightning talk for content-select
  • bug 1421229 ASSIGNED:: Render dropdown menu of <select> in content process
    • Debug the APZ issue (bug 1421229)
    • Fixed the position / size / top-level issue for content dropdown
    • Find the correct parent of the dropdown frame when it need to reflow
    • Find the correct parent of the dropdown frame when it need to reflow (bug 1421229)
    • Fix the event handling issues of selection and toggle (bug 1421229)
    • Fix the issue of dropdown hiding when click scrollbar (bug 1421229)
    • Propose my implementation plan and ask for feedback (bug 1421229)

Ya-Chieh Wu

  • bug 1422238 NEW:: [BC] Consider to add some comments or rename some variables in nsTableFrame::CalcBCBorders
    • File Bug 1422238
  • bug 752790 NEW:: Input padding covers text when the padding is greater than (TextHeight - InputHeight)/2
    • Bug 752790 wip
  • bug 1421887 NEW:: [BC] |ResetBStartStart| might introduce weird borders if we don't get the row index right.
    • File Bug 1421887
    • Work on reftest for Bug 1421887

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics