TPE-Layout/2017-10-17

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

  • 勞資會議勞方代表選舉
    • Layout - Ting-Yu Lin

Weekly Sharing

Weekly Status

Astley Chen

  • Mozregression for https://webcompat.com/issues/12504, flex regression since 2014-07-23.
  • bug 1406658 NEW:: calc() does not work in counter-* properties
    • Bug 1406658 - calc() in stylo-behavior-changes
  • bug 1407525 NEW:: stylo: layout/reftests/webkit-box/webkit-display-values-1.html is always failure on Android/stylo
    • Bug 1407525 - -moz-inline-box seems broken and ni dholbert to check.

Boris Chiou

  • bug 1282691 RESOLVED::FIXED Assertion failure: !IsWaitingToPause(aAnimation) (Animation is already waiting to pause)
    • Reviewed bug 1282691 - Assertion failure: !IsWaitingToPause(aAnimation)
  • bug 1303235 ASSIGNED:: stylo: Implement KeyframeEffectReadOnly::CalculateCumulativeChangeHint
    • Fixed the crashes on Linux because of too many borrows for bug 1303235, however, there are are still some incorrect transition results in some test files
    • Updated patches for bug 1303235 - stylo: Implement KeyframeEffectReadOnly::CalculateCumulativeChangeHint, but still have some try failures
    • Wrote patches to minor refactor some duplicated code for bug 1303235 - stylo: Implement KeyframeEffectReadOnly::CalculateCumulativeChangeHint

Cameron McCormack

  • Address review comment for https://github.com/servo/servo/pull/18793
  • Filed a bunch of bugs for removing dependencies on old style system
  • Reviewed https://github.com/servo/servo/pull/18826
  • Reviewed https://github.com/servo/servo/pull/18847
  • Reviewed https://github.com/servo/servo/pull/18884
  • bug 1405311 RESOLVED::FIXED Remove :-moz-system-metric pseudo-class, replace with system metric media queries.
    • Reviewed a patch in bug 1405311
  • bug 1407522 RESOLVED::FIXED stylo: tweak style sheet invalidations to bail out to dirtying the whole document less
    • Requested uplift for bug 1407522
    • Uploaded patch for bug 1407522
  • bug 1363088 RESOLVED::FIXED Inheritance logic in HasAuthorSpecifiedRules is slightly wrong for text-shadow
    • Reviewed bug 1363088
  • bug 1407952 RESOLVED::FIXED stylo: Use stylo for Element::Closest.
    • Reviewed bug 1407952
  • bug 1408315 RESOLVED::FIXED remove unused nsCSSParser local variable in HTMLSourceElement::UpdateMediaList
    • Uploaded patch for bug 1408315
  • bug 1407843 RESOLVED::FIXED Remove nsICSSPseudoComparator and integrate the only instance into nsCSSRuleProcessor directly
    • Reviewed bug 1407843
  • bug 1408322 ASSIGNED:: replace inDOMUtils.CssPropertyIsValid() with CSS.supports()
    • Uploaded new patch for bug 1408322
  • bug 1407246 RESOLVED::FIXED stylo: skip CustomPropertiesMap comparisons when we can
    • Uploaded new patches for bug 1407246
  • bug 1408312 ASSIGNED:: use Servo for color parsing in various places where we currently use nsCSSParser
    • Uploaded patches for bug 1408312
  • bug 1407832 NEW:: Stylo: Flags inherited by for_inheritance are suspicious
    • Reviewed bug 1407832
  • bug 1407847 NEW:: stylo: Enable stylo on XUL document without system principal
    • Reviewed bug 1407847
  • bug 1402109 RESOLVED::FIXED InvalidArrayIndex_CRASH in [@ SVGTextFrame::GetRotationOfChar]
    • Reviewed bug 1402109
  • bug 1407463 RESOLVED::FIXED stylo: Drop unused pseudo nsAtom from some methods for ServoStyleSet
    • Reviewed bug 1407463
  • bug 1408672 NEW:: stylo: Hover invalidation is broken on quirks mode
    • Reviewed bug 1408672

CJ Ku

  • bug 1402157 ASSIGNED:: stylo: Assertion failure: aFrame->HasImageRequest() (why call me?) in [@ mozilla::css::ImageLoader::DisassociateRequestFromFrame]
    • Bug 1402157 WIP

Eric Tsai

  • Issue triage
  • Survey webcompat.com issue report form improvement

Jeremy Chen

  • bug 1408724 RESOLVED::INVALID Firefox 57 cannot render VMware page correctly
    • Triaged and resolved Bug 1408724
  • bug 1408851 ASSIGNED:: negative calc()s for inset() should be valid
    • Filed Bug 1408851
    • Uploaded patchset to Bug 1408851
  • bug 1403077 RESOLVED::FIXED stylo-blocklist: add support for a list of domains that should use the old Gecko style system instead of Stylo
    • Rebased patchset for beta uplift [Bug 1403077]
    • Uplift patchset merged to beta [Bug 1403077]
  • bug 1407098 RESOLVED::FIXED stylo-blocklist: put a nightly only domain in stylo blocklist for testing
    • Landed Bug 1407098
    • Uploaded a patch [Bug 1407098]
  • bug 1378368 ASSIGNED:: getComputedStyle returns wrong value for basic-shapes containing calc() that should resolve to negative value
    • Landed Bug 1378368
    • Uploaded patchset and request for review [Bug 1378368]
  • bug 1407096 RESOLVED::FIXED stylo-blocklist: measure the performance impact for enabling the blocklist mechanism
    • Verified the performance impact and resolved the bug [Bug 1407096]
  • bug 1407911 NEW:: [meta] stylo-blocklist: update stylo-blocklist preference using a system addon
    • Filed Bug 1407911
    • Updated the template patch [Bug 1407911]
    • Uploaded a template patch [Bug 1407911]

Louis Chang

  • bug 1403410 - Checkbox has 3 states – empty / outlined / with check-mark.
    • simplify test case and look into the problem
  • bug 1368555 - Implement -webkit-appearance
    • study -webkit-appearance/-moz-appearance/appearance related bugs, knowledge, background

Ting-Yu Lin

  • Study the spec related to shape image https://drafts.csswg.org/css-shapes/#shapes-from-image
  • bug 1399204 RESOLVED::FIXED Intermittent test_accessiblecaret_selection_mode.py AccessibleCaretSelectionModeTestCase.test_long_press_to_select_when_partial_visible_word_is_selected | AssertionError: 'aaaaaaaa' != u
    • Landed bug 1399204.
    • Uploaded a patch for bug 1399204.
  • bug 1408841 NEW:: Remove preference "layout.css.filters.enabled"
    • Filed bug 1408841.
  • bug 1404854 RESOLVED::FIXED Cannot scroll page by dragging text selection handles to the edge of the screen
    • Landed bug 1404854.
  • bug 1378368 ASSIGNED:: getComputedStyle returns wrong value for basic-shapes containing calc() that should resolve to negative value
    • Reviewed bug 1378368.

Tommy Kuo

  • bug 1399310 NEW:: Decorations get drawn multiple times with selections
    • Fix the clip region for text-shadow and text-overflow (bug 1399310)
    • Found the clip region is still wrong for the text with shadow on selection. (bug 1399310)
    • Upload a new patch to ask review (bug 1399310)
    • Upload a new patch to fix the clip region for more complicated situation with writing-mode, direction attribute and RTL text. (bug 1399310)
  • bug 1154677 NEW:: [e10s] <select> issues tracking
    • Look at all the e10s-select bugs roughly (bug 1154677)
  • bug 1408826 NEW:: Decorations get drawn multiple times with selections for `text-combine-upright`
    • File a bug (bug 1408826)

Ya-Chieh Wu

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics
Retrieved from "https://wiki.mozilla.org/index.php?title=TPE-Layout/2017-10-17&oldid=1182355"