TPE-Layout/2017-08-29

Weekly Announcement

• 2017 Team Building
  • Event planner nomination.
  • Event focus discussion.

Weekly Sharing

Weekly Status

Astley Chen

• Done the new regressions check of FF56. Status looks good. http://mozilla.github.io/releasehealth/
• bug 1392314 NEW:: stylo: causes memory consumption to double for gmail
  • Bug 1392314 - doing local test and see how memory consumption goes.
  • Bug 1392314 - done verification and found a ~60MB memory variation when loading gmail inbox on stylo.

Boris Chiou

• bug 1387990 RESOLVED::FIXED stylo: Many interpolations of transform are failed in test_transitions_per_property.html
  • Landed bug 1387990 - stylo: Many interpolations of transform are failed in test_transitions_per_property.html
• bug 1390039 NEW:: stylo: Implement compute_distance for mismatched transform lists
  • Wrote patches for bug 1390039 - stylo: Implement compute_distance for mismatched transform lists

Cameron McCormack

• Reviewed https://github.com/servo/servo/pull/18191
• bug 1393636 RESOLVED::FIXED Report memory usage of Gecko style structs separately
  • Reviewed bug 1393636
• bug 1387913 RESOLVED::FIXED stylo: Rules are not cloned properly before mutation on shared stylesheet
  • Reviewed bug 1387913
• bug 1342951 NEW:: Expensive sync reflows when holding the down key on google presentations
  • Reviewed bug 1342951
• bug 1385154 RESOLVED::FIXED stylo: Consider rethinking how EagerPseudoStyles for ::before and ::after work.
  • Reviewed bug 1385154
• bug 1394271 ASSIGNED:: stylo: check matching rules before cascading eager pseudos
  • Uploaded patch for bug 1394271
• bug 1394297 ASSIGNED:: stylo: don't mutate style structs when attempting to store the same value
  • Uploaded patch for bug 1394297
• bug 1367635 NEW:: stylo: consider caching style structs in the rule tree
  • Maybe discovered source of style struct memory usage in bug 1367635
  • Uploaded WIP patch for bug 1367635, which is green on try, but which doesn't save as much memory as I expect...

CJ Ku

• Setup windows notebook
• bug 1390088 RESOLVED::FIXED SVG within SVG (embedded) not displaying correctly in 56.0b2.
  • Bug 1390088 landed
  • Bug 1390088 upload patches according to jwatt's review comment
• bug 1385239 NEW:: incorrect SVG mask with transformed/filtered graphic object
  • Bug 1385239 r?
  • Bug 1385239 upload patches
  • Bug 1385239 upload a test case
• bug 1389712 NEW:: switching to a Google Slides tab is slow (long repaint)
  • Bug 1389712 profilkling
• bug 1358239 RESOLVED::FIXED pulse and sns notifier lag due to running `hg log`
  • Bug 1358239 upload a test case

Eric Tsai

• Issue triage and diagnosis
• WebCompat to Bugzilla extension https://github.com/MDTsai/webcompat-to-bugzilla/issues
  • Fetch product/component from bugzilla, cache and restore in local storage
  • Fill detail information while open new bug
  • Add to duplicate bug's see also field then close existing issue

Farmer Tseng

• bug 1382509 RESOLVED::FIXED Build PDFium as a separate library instead of linking it into libxul
  • Landed on Bug 1382509
  • Uploaded patch, r? on Bug 1382509

Jeremy Chen

• bug 1375332 RESOLVED::FIXED stylo: font-size doesn't always respond to language-specific minimum size when using charset-derived language
  • Landed Bug 1375332
  • Updated patchset and address reviewer's comment [Bug 1375332]
• bug 1391120 RESOLVED::FIXED stylo: Calc with negative values on the right side serializes with "+"
  • Triaged Bug 1391120
• bug 1390105 UNCONFIRMED:: [webvtt] German umlauts leave black border which makes them unreadable on white background
  • Provided comments [Bug 1390105]
• bug 1391341 ASSIGNED:: stylo: Decreased font size when lang="zh"
  • Investigated [Bug 1391341]
  • Investigated, discovered the root cause [Bug 1391341]
  • Uploaded a patch for review [Bug 1391341]
• bug 1392910 RESOLVED::FIXED Remove unnecessary pref setting for CSS text-justify property in testing profile
  • Filed and landed [Bug 1392910]
• bug 1390457 RESOLVED::DUPLICATE Stylo: Opening Inspector changes the font used by the page
  • Provided comments and NI the reporter to verify if it is fixed in part of my previous work [Bug 1390457]
• bug 1386901 RESOLVED::WORKSFORME stylo: CSS property with leading period is not reported as an error
  • Investigated Bug 1386901
• bug 1391178 NEW:: Scrolling in a popup should not cause scrolling in its underlying content
  • Replied NI and updated a better STR [Bug 1391178]

Louis Chang

• bug 1352238 - Implement a native theme for checkbox/radio form controls on Android
  • study | WIP | r?

Ting-Yu Lin

• Uploaded a Servo PR https://github.com/servo/servo/pull/18213
• bug 1374247 NEW:: stylo: We don't implement the hack to allow child combinators to match across XBL <children> elements (could we remove it?).
  • Investigated why reftest xbl-children-1.xhtml fails, and left a comment 7 in bug 1374247.
• bug 1393618 RESOLVED::DUPLICATE Reftests and crashtests fail to run locally on MacOS
  • Resolved bug 1393618 as a dup.
• bug 1394304 NEW:: Support always open urlbar result in a new tab
  • Filed bug 1394304 and uploaded a patch.
• bug 1388165 RESOLVED::FIXED Stylo: DevTools test using XBL triggers crashes in ServoStyleSet::StyleRuleMap
  • Landed bug 1388165.
  • Uploaded a patch for bug 1388165.

Tommy Kuo

• bug 1391198 - stylo: The order of rules in DevTools is not specificity order when all declarations in a rule are !important.
  • Find the root cause
  • Trace code
  • WIP

Ya-Chieh Wu

• bug 895096 NEW:: border-collapsed table borders have inconsistent widths when device pixel scale is not 1 (zoom)
  • Bug 895096 r?
  • Wip for Bug 895096
  • Working on bug 1379038 and bug 895096 to figure out how to divide the border-collapse table's border correctly
• bug 1379038 ASSIGNED:: Border Collapse causing 1px off
  • Working on bug 1379038 and bug 895096 to figure out how to divide the border-collapse table's border correctly

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics