TPE-Layout/2017-08-01

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

  • 2017Q3 goals on Workday by 8/15.
  • Offsite feedback
    • Intermittent rate growing analysis.
      • Orange Factor and information on Try server.
    • Reftest for CSS transition and animation - how do we snapshot intermediate transition result?
    • Layout debugging 101 (using rr)

Weekly Sharing

Weekly Status

Astley Chen

  • bug 1384386 NEW:: Stylo: fails to render play/stop button on radiomitre.cienradios.com
    • Bug 1384386 - Seems fixed in 0727 nightly build. ni reporter to verify the build.
  • bug 1384602 NEW:: stylo: Squashed boxes in YouTrack Agile Boards view
    • Bug 1384602 - Example created but failed to reproduce it. ni reporter.
  • bug 1381732 RESOLVED::FIXED IME is disabled after changing window focus
    • (bug 1381732) P1 and set tracking flag
  • bug 1379306 ASSIGNED:: Position absolute not work as expected in table with border collapse
    • Bug 1379306 - won't fix in FF56.
  • bug 1379516 NEW:: stylo: incorrect restyle marker for animations
    • Triage bug 1379516 and assigned to Tommy.
  • bug 1378672 NEW:: Specific SVG not completely rendered in firefox (at least)
    • Bug 1378672 - regression, SVG, windows only
  • bug 1384854 RESOLVED::DUPLICATE Stylo: Crash in alloc::oom::oom
    • Bug 1384854 - find the STR that is 100% reproducible.
  • bug 1362380 NEW:: The Home page is scrolled to the top when opening a photo on LinkedIn
    • Bug 1362380 - regression, webcompat
  • bug 945237 NEW:: Pattern fill does not work on SVG elements with large offset
    • Bug 945237 - to be clarified as it seems fixed now.
  • bug 1341438 RESOLVED::FIXED Ship Report Site Issue button to Dev Edition channel
    • Bug 1341438 - ni?(mike taylor) for clarifying issue on enabling webcompat reporter addon on aurora(55.0b11).

Boris Chiou

  • bug 1381386 RESOLVED::FIXED stylo: Crash in mozalloc_abort | abort | style::properties::Template:Impl::to_css<T>
    • Fixed bug 1381386 - stylo: Crash in mozalloc_abort | abort | style::properties::Template:Impl::to_css<T>
    • Landed bug 1381386 - stylo: Crash in mozalloc_abort | abort | style::properties::Template:Impl::to_css<T>
  • bug 1384014 RESOLVED::FIXED Stylo: Crash in mozalloc_abort | abort | core::result::unwrap_failed<T> | style::properties::animated_properties::Template:Impl::compute_distance
    • Fixed bug 1384014 - Stylo: Crash in mozalloc_abort | abort | core::result::unwrap_failed<T> | style::properties::animated_properties::Template:Impl::compute_distance
    • Landed bug 1384014 - Stylo: Crash in mozalloc_abort | abort | core::result::unwrap_failed<T> | style::properties::animated_properties::Template:Impl::compute_distance
    • Wrote a patch for bug 1384014 - Stylo: Crash in mozalloc_abort | abort | core::result::unwrap_failed<T> | style::properties::animated_properties::Template:Impl::compute_distance

Cameron McCormack

  • Submitted https://github.com/servo/servo/pull/17901
  • bug 1384789 RESOLVED::FIXED Stylo: DevTools needs a way to filter out import rules reached via an import loop
    • Reviewed a patch in bug 1384789
  • bug 1381851 ASSIGNED:: Stylo: Flash click to play doesn't display on video elements when Stylo is enabled
    • Reviewed some patches in bug 1381851
  • bug 1384275 VERIFIED::FIXED stylo: icon fonts are not loaded on fluentcpp.com
    • Started investigating bug 1384275
  • bug 1370153 ASSIGNED:: stylo: Re-enable dom/xul/crashtests/461917-1.xhtml
    • Investigating bug 1370153
  • bug 1384868 RESOLVED::FIXED Simplify a bit RuleNodeCacheConditions.
    • Reviewed bug 1384868
  • bug 1383981 RESOLVED::FIXED Stylo: Robohornet CSS selectors test OOMs
    • Reviewed bug 1383981
  • bug 1384625 RESOLVED::FIXED stylo: heap write hazards under Servo_GetEmptyVariables
    • Uploaded patch for bug 1384625
  • bug 1383791 RESOLVED::FIXED If the URL value of a css mask property does not consist of fragment, do not trigger svg resource donwload
    • Reviewed bug 1383791
  • bug 1375383 RESOLVED::FIXED stylo: change to -moz-binding doesn't trigger frame reconstruction
    • Uploaded patch for bug 1375383
  • bug 1381137 RESOLVED::FIXED stylo: "Declaration dropped"/"Skipped to next declaration" missing from parser error messages
    • Reviewed bug 1381137
  • bug 1381083 RESOLVED::FIXED Stylo: Percentage based position values reported in different units over time
    • Reviewed bug 1381083
  • bug 1382077 RESOLVED::FIXED stylo: Restyle should not be triggered when viewport size changes while there is no media query rules
    • Reviewed bug 1382077
  • bug 1384719 RESOLVED::FIXED "error: implicit conversion of nullptr constant to 'bool'" in nsCSSVisitedDependentPropList.h
    • Reviewed bug 1384719
  • bug 1374966 RESOLVED::FIXED stylo: ASSERTION: Unexpected UpdateTransformLayer hint while running test_transitions_per_property.html
    • Reviewed bug 1374966
  • bug 1381143 NEW:: Stylo: No CSS error reported for invalid color values
    • Reviewed bug 1381143
  • bug 1384542 RESOLVED::FIXED stylo: kill GetParentAllowServo.
    • Final review of one patch in bug 1384542
    • Reviewed bug 1384542
  • bug 1383988 RESOLVED::FIXED stylo: Image resizer in contenteditable again doesn't show up
    • Submitted patch for bug 1383988
  • bug 1301245 RESOLVED::FIXED stop trying to load SVG mask references as images
    • Reviewed bug 1301245
  • bug 1381821 ASSIGNED:: stylo: hover state style doesn't refresh correctly
    • Investigated bug 1381821
  • bug 1384065 VERIFIED::FIXED Stylo: vk.com lightbox gallery is broken
    • Reviewed bug 1384065
  • bug 1384493 NEW:: dom/base/test/test_link_stylesheet.html fails when we enable rcwn, due to speculative loading style
    • Initial review for bug 1384493

CJ Ku

  • bug 1271983 NEW:: Animated SVG image is blurred in FF 46
    • Bug 1097464 learn how to handle preserves-3d by compositor, and why it cause blur issue in bug 1271983
  • bug 1385159 RESOLVED::FIXED Use autoarryay to prevent buffer allocation in DrawTargetSkia::DrawGlyphs
    • Bug 1385159 filed
    • Bug 1385159 landed
  • bug 1301245 RESOLVED::FIXED stop trying to load SVG mask references as images
    • Bug 1301245 landed
    • Bug 1301245 upload new patches
  • bug 1029610 RESOLVED::FIXED Discard all xul reftest on B2G
    • Bug 1029610 landed
  • bug 1383791 RESOLVED::FIXED If the URL value of a css mask property does not consist of fragment, do not trigger svg resource donwload
    • Bug 1383791 landed
  • bug 1385929 NEW:: Find a way to prevent duplicate gfxContext::Save/Restore
    • Bug 1385929 filed
  • bug 1384025 NEW:: Two color children disappear after toggling to transform-style:flat.
    • Bug 1384025 filed
  • bug 1385861 ASSIGNED:: Fine tune nsDisplaySVGText::Paint
    • Bug 1385861 filed
    • Bug 1385861 upload patches
  • bug 1097464 RESOLVED::FIXED Move preserve-3d handling into the compositor
    • Bug 1097464 learn how to handle preserves-3d by compositor, and why it cause blur issue in bug 1271983
  • bug 1382909 NEW:: Enable prerendering/OMTA for masked element
    • Bug 1382909 comment

Eric Tsai

  • Issue triage and diagnosis
  • Review webcompat system addon bug 1338586 1383989 1371442

Farmer Tseng

  • bug 1358076 ASSIGNED:: [PDF gtest] Implement unit test for PDFViaEMFPrintHelper
    • Uploaded patch, f? on Bug 1358076
  • bug 1367948 RESOLVED::FIXED There is some garbage on EMF while converting PDF to EMF
    • Landed on Bug 1367948
  • bug 1385779 ASSIGNED:: [PDF gtest] create multiple PDFViaEMFPrintHelper to load each PDF file
    • Filed Bug 1385779
  • bug 1382512 ASSIGNED:: [PDF gtest] convert EMF to bitmap and compare the bitmap content with reference
    • Uploaded a WIP patch on Bug 1382512
  • bug 1382509 ASSIGNED:: Pull out PDFium from xul
    • Install pdfium.dll into installer on Bug 1382509
    • Uploaded patch, f? on Bug 1382509
    • Uploaded patches, updated try result, f? on Bug 1382509

Jeremy Chen

  • bug 1374513 RESOLVED::FIXED stylo: filter serialization is different
    • Replied ni?, confirmed and reopened the bug [Bug 1374513]
    • Resolved [Bug 1374513]
  • bug 1382742 VERIFIED::FIXED stylo: site issue: Broken hover transition on fastaim.de
    • Confirmed that patch for bug 1381235 can fix the remaining issue [Bug 1382742]
  • bug 1355721 ASSIGNED:: stylo: Implement @font-feature-values rule support
    • Reassign to Nazım [Bug 1355721]
  • bug 1380368 RESOLVED::DUPLICATE stylo: site issue: visual bug with google docs star not visible until mouse over
    • Closed Bug 1380368
  • bug 1384911 RESOLVED::DUPLICATE Stylo: Content added using ::after on Pontoon does not appear
    • Triaged a little bit and CCed Shing [Bug 1384911]
  • bug 1381235 RESOLVED::FIXED stylo: issue with transitioning on visited links
    • Confirmed that patch for bug 1381235 can fix the remaining issue [Bug 1382742]
    • Got r+ and updated the patch according to reviewer's comment [Bug 1381235]
    • Landed Bug 1381235
    • Landed the fix [bug 1381235]
    • Updated patches for review [Bug 1381235]
    • Uploaded a further reduced/simplified testcase, tracing the code path for transitioning on visited link [Bug 1381235]
    • Uploaded a patch, try looks fine, ask for review, still work on testcase [Bug 1381235]
    • Uploaded a wip for test, but still need some tweaks, not ready for review yet [bug 1381235]

Louis Chang

  • bug 1385745 Only first line is visible in inline element with filter and box-decoration-break:clone
    • WIP
  • bug 878346 make transform="" a presentation attribute for the transform property
    • study, WIP

Shing Lyu

Stylo

Servo

  • #11361 - Using rustup to manage servo's build dependency

Evangelism

  • Preparing COSCUP talk

Ting-Yu Lin

  • bug 1381851 ASSIGNED:: Stylo: Flash click to play doesn't display on video elements when Stylo is enabled
    • Update patches for review for bug 1381851.
    • Uploaded a patch for bug 1381851.
    • Uploaded new patches for bug 1381851.
  • bug 1384446 RESOLVED::DUPLICATE Crash in mozalloc_abort | NS_DebugBreak | ErrorLoadingSheet
    • Investigate bug 1384446.

Tommy Kuo

  • bug 1377158 NEW:: stylo: Enable stylo for SVG-as-an-image.
    • Debug for try failures (bug 1377158)
    • Investigate the failure of image/test/crashtests/694165-1.xhtml (bug 1377158)
    • Landed (bug 1377158)

Ya-Chieh Wu

  • Debug bug1379306
  • bug 1379306 ASSIGNED:: Position absolute not work as expected in table with border collapse
    • Bug 1379306 r?
  • bug 1384031 NEW:: the behavior of border-radius properties applied to internal table elements
    • Bug 1384031 filed
  • bug 1375518 RESOLVED::FIXED Border radius is not painted correctly on border-collapsed table-cell elements
    • Bug 1375518 r+ and rebase for landing

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics
Retrieved from "https://wiki.mozilla.org/index.php?title=TPE-Layout/2017-08-01&oldid=1177025"