TPE-Layout/2017-05-23
From MozillaWiki
Contents
Weekly Announcement
- Introducing Nightly soft code freeze - Ritu
- Do:
- Be ready to backout patches that cause crash spikes, new crashes, severe regressions
- Monitor new regressions and escalate merge blockers
- Support release management to prioritize fixing merge blockers
- Do Not:
- Land a risky patch or a large patch a week before Merge day
- Land new features a week before Merge day
- Flip prefs that enable new Features that were untested in Nightly cycle
- Plan to kick off new experiments
- Do:
Weekly Sharing
- Session-based-test-management (SBTM): Shing Lyu
- http://www.satisfice.com/sbtm/
- http://www.satisfice.com/presentations/htmaht.pdf
- Example for stylo: https://docs.google.com/spreadsheets/d/1BaNYE0A7pXEZD6R82G4epopdQOmDn1iuGt0OujVulNg/edit?usp=sharing
- Good book on software testing https://www.amazon.com/Perfect-Software-Other-Illusions-Testing/dp/0932633692
Weekly Status
Astley Chen
- (status-bot) Addressed https://github.com/astleychen/status-bot/issues/4.
- bug 1338767 Invalid bug or security bug
- (bug 1338767) revisit crash stat and is still a low volume crash. ni for help.
- bug 1362412 ASSIGNED:: foofighters.com is still slow to animate
- (bug 1362412)[qf] Need a follow-up in comment 16 to avoid overpainting in table frames.
- bug 1362817 NEW:: Printing from FireFox 53.0 32-bit on Linux Mint 17 qiana xfce 32-bit the datetime on the page prints as 12/31/69. This is new as of my last update.
- (bug 1362817) Reproducing on mint linux. macOS and Windows are fine.
- bug 1362924 Invalid bug or security bug
- (security bug 1362924) Fix potential reentry into DocumentViewer from call sites which includes nsAutoScriptBlocker.
- bug 1352205 NEW:: Avoid running the refresh driver when the page is in background
- (bug 1352205) what's the best solution to avoid refresh tick on background tab ?
Boris Chiou
- Reviewed servo issue #16964 - stylo: Avoid FFI calls to get animation rules when known not-needed
- bug 1361663 NEW:: stylo: The interpolated result of ServoAnimationValue is not equal to that of StyleAnimationValue
- Debugged bug 1361663 - stylo: The interpolated result of ServoAnimationValue is not equal to that of StyleAnimationValue
- bug 1292283 ASSIGNED:: stylo: Enable test_transitions_per_property.html
- Investigated possible exception for bug 1292283 - stylo: Enable test_transitions_per_property.html
- bug 1334036 RESOLVED::FIXED stylo: Support off-main-thread animations
- Addressed comments and wrote a patch to trigger animation-only restyle while we have an event with coordinates for bug 1334036
- Addressed comments and wrote a patch to trigger animation-only restyle while we have an event with coordinates for bug 1334036 - stylo: Support off-main-thread animations
- Landed bug 1334036 - stylo: Support off-main-thread animations
- bug 1329077 RESOLVED::FIXED Revert opening a new window hack for test_animation_performance_warning.html
- Reviewed bug 1329077 - Revert opening a new window hack for test_animation_performance_warning.html
- bug 1365855 NEW:: stylo: Trigger an animation-only restyle when we handle an event with coordinates for SMIL
- Filed bug 1365855 - stylo: Trigger an animation-only restyle when we handle an event with coordinates for SMIL
- bug 1301611 RESOLVED::FIXED Need test cases that changedAnimations is notified to mutation observers when keyframes are changed
- Reviewed bug 1301611 - Need test cases that changedAnimations is notified to mutation observers when keyframes are changed
- bug 1365091 RESOLVED::FIXED stylo: Enable transition-and-animation-with-different-durations.html
- Reviewed bug 1365091 - stylo: Enable transition-and-animation-with-different-durations.html
- bug 1366441 RESOLVED::FIXED Permaorange in test_animation_observers_sync.html when Gecko 55 merges to mozilla-beta on 2017-06-12
- Landed bug 1366441 - Permaorange in test_animation_observers_sync.html when Gecko 55 merges to mozilla-beta on 2017-06-12
- bug 1346049 RESOLVED::FIXED stylo: Enable reftestts for checking stacking context in layout/reftests/web-animations
- Tested 100 trials for bug 1346049 - stylo: Enable reftestts for checking stacking context in layout/reftests/web-animations
Cameron McCormack
- Submitted https://github.com/servo/servo/pull/16906
- Updated patches for https://github.com/servo/servo/pull/16906
- bug 1364863 RESOLVED::FIXED Don't force stylo reftest sandbox attribute at build-time
- Reviewed bug 1364863
- bug 1364845 RESOLVED::FIXED stylo: add support for a "re-run selector matching on children only" restyle hint
- Landed bug 1289868 and bug 1364845
- bug 1366144 RESOLVED::FIXED stylo: ::after pseudo element under a parent with transition didn't show up
- Reviewed some more stuff over the weekend (bug 1366144, bug 1364871, bug 1363640, bug 1366142, bug 1366427)
- bug 1364871 RESOLVED::FIXED stylo: Restyle ::-moz-list-bullet and ::-moz-list-number pseudo-elements (for nsBulletFrame)
- Reviewed some more stuff over the weekend (bug 1366144, bug 1364871, bug 1363640, bug 1366142, bug 1366427)
- bug 1345697 RESOLVED::FIXED stylo: Implement access to CSSKeyframesRule and CSSKeyframeRule
- Reviewed bug 1345697
- bug 1363640 NEW:: stylo: Enable stylo for XBL documents
- Reviewed some more stuff over the weekend (bug 1366144, bug 1364871, bug 1363640, bug 1366142, bug 1366427)
- bug 1365902 RESOLVED::FIXED stylo: Make RebuildAllStyleData asynchronous.
- Reviewed bug 1365902
- bug 1289868 RESOLVED::FIXED stylo: Use the result of CalcStyleDifference to cull parallel DOM traversal
- Investigated some failures for bug 1289868
- Landed bug 1289868 and bug 1364845
- Uploaded new patches for bug 1289868
- Uploaded patches for bug 1289868
- bug 1364862 RESOLVED::FIXED stylo: Make PostRebuildAllStyleDataEvent do the style flush async.
- Reviewed bug 1364862
- bug 1366142 RESOLVED::FIXED stylo: Crash while clicking a line on waaark.com: Assertion failure: aFrame || (aHint & nsChangeHint_ReconstructFrame)
- Reviewed some more stuff over the weekend (bug 1366144, bug 1364871, bug 1363640, bug 1366142, bug 1366427)
- bug 1366427 NEW:: stylo: Backdrop pseudo should not inherit.
- Reviewed some more stuff over the weekend (bug 1366144, bug 1364871, bug 1363640, bug 1366142, bug 1366427)
- bug 1363482 NEW:: Pre-load files needed during startup on a background thread
- Reviewed one patch of bug 1363482
- bug 1339629 NEW:: stylo: ServoStyleSheets don't handle modification in the presence of cloned inners correctly
- Reviewed bug 1339629
- bug 1365831 RESOLVED::FIXED dynamic layout change that resizes conditionally processed outer SVG triggers "expected aContainer to be NS_FRAME_IS_DIRTY" assertion
- Reviewed bug 1365831
- bug 1364361 ASSIGNED:: stylo: AllChildrenIterator doesn't find NAC created by non-primary frames of elements
- Reworking bug 1364361 patch for review comments
- Uploaded new patch for bug 1364361
- Uploaded new patches (again) for bug 1364361
- bug 1364799 RESOLVED::FIXED stylo: Inserting new @keyframes rule doesn't trigger restyle
- Reviewed one patch of bug 1364799
- bug 1342289 NEW:: stylo: memory leak when creating sheets via script, dom/html/crashtests/795221-3.html
- Reviewed bug 1342289
- bug 1366657 NEW:: stylo: NS_ERROR_NOT_AVAILABLE occurs when modifying style for a keyframe rules obtained by cssom
- Reviewed bug 1366657 (just now)
- bug 1366709 NEW:: stylo: Parse :-moz-placeholder as a pseudo-class, but never match it.
- Reviewed bug 1366709
CJ Ku
- bug 1348490 ASSIGNED:: stylo: need support for ::-moz-placeholder pseudo element
- Bug bug 1348490 update patch
- bug 1205475 RESOLVED::FIXED nsIFrame::HasOpacityInternal takes a lot of time
- Bug bug 1205475 WIP
Eric Tsai
- Paternity leave (5 days)
Farmer Tseng
- bug 1345789 NEW:: [Mortar] [Windows] setup an IPC between parent process and plugin process
- Build PDFium library from Chromium, debuging garbage issue, Bug 1345789
- Debug printing garbage while printing 1040 PDF form, Bug 1345789
- Test WIP patches and debug issues, Bug 1345789
- bug 1365814 NEW:: [JSPlugin] Can not generate PDF file while using "Microsoft Print to PDF" driver in Win10
- Filed Bug 1365814
Jeremy Chen
- bug 1056516 RESOLVED::FIXED presence of explicit soft-hyphen in a word should override automatic hyphenation
- Reviewed MDN and release notes [Bug 1056516]
- bug 1365900 ASSIGNED:: stylo: Parsing for @font-feature-values
- Filed Bug 1365900 and uploaded a WIP
- Updated wip [Bug 1365900]
- Updated wip patch [Bug 1365900]
- bug 1355721 ASSIGNED:: stylo: Implement @font-feature-values rule support
- Figure ou the life time of Rust and keep working on parsing part [Bug 1355721]
Louis Chang
- bug 1358347 - Implement back-end part of find whole-word function
- WIP
- bug 1347440 - Integrate building rpc.cc into mozbuild instead of checking it into m-c
- Address glandium's comment & discuss with glandium
- bug 1365814 - Can not generate PDF file while using "Microsoft Print to PDF" driver in Win10
- WIP
- bug 1246741 - Add more test case for basic shapes clipping in SVG content
- Study
Shing Lyu
- Exploratory testing on Stylo https://docs.google.com/spreadsheets/d/1BaNYE0A7pXEZD6R82G4epopdQOmDn1iuGt0OujVulNg/edit?usp=sharing
- Bug 1359288 - Solve the android reftest error message
Ting-Yu Lin
- Submit PR to fix a wrong debug message https://github.com/servo/servo/pull/16918
- bug 1290276 NEW:: stylo: XBL <stylesheet> support
- Upload WIP patches for bug 1290276.
- bug 1365390 NEW:: Intermittent w3c-css/submitted/shapes1/shape-outside-ellipse-050.html | application timed out after 330 seconds with no output
- Reply needinfo for bug 1365390
- bug 1366163 NEW:: stylo: rendering of <video controls> and <audio controls> is wrong
- File bug 1366162 and bug 1366163.
- bug 1366162 NEW:: stylo: support -moz-context-properties
- File bug 1366162 and bug 1366163.
- bug 1312328 RESOLVED::FIXED Remove CSS pref "layout.css.variables.enabled"
- Reviewed documentation changes for bug 1326409 and bug 1312328.
- bug 1363382 NEW:: Firefox hang
- Replay needinfo for bug 1363382
- bug 1326409 RESOLVED::FIXED Implement the rendering of basic shape polygon() for CSS shape-outside
- Reviewed documentation changes for bug 1326409 and bug 1312328.
Tommy Kuo
- bug 1358993 ASSIGNED:: stylo: ServoStyleSheet::ParseSheet should disconnect child sheets / mRuleList, and re-use child sheets
- Can get import rule from servo, and try to get the imported sheet (bug bug 1358993)
- Finished the first version of patches and ask feedback (bug bug 1358993).
- Refactor LoaderReusableStyleSheets to store StyleSheet objects. (bug bug 1358993)
Ya-Chieh Wu
- bug 1360494 RESOLVED::FIXED [Mortar] 'stage-package' failed after adding '--enable-mortar' configuration
- Land Bug bug 1360494
Rule of Thumb
Status code:
- OOAD: In analysis or design phase.
- WIP: working on WIP patch.
- feedback(f): feedback a patch
- feedback?(f?): WIP is ready for feedback grant.
- feedback+(f+): Get positive feedback.
- feedback-(f-): Get negative feedback.
- review(r): review a patch.
- review?(r?): patch is under review
- review+(r+): get review+ and ready to check-in
- review-(r-): get negative review feedback. Fix problems and switch back to r? again.
- land: patch check in.
- debug: Figure out the root cause of a bug/ try to repro that bug, etc...
- file: file a bug
- PTO: take personal leave
- interview(I)
- study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
- presentation
- Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
- WIKI/ MDN article writing.
- If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
- Do a presentation of technical topics