Releases/Thunderbird 45.1.0/BuildNotes

From MozillaWiki
Jump to: navigation, search

build 1

build 2

build 3


  • Issues
  • build 1 compile error for macosx64
/builds/slave/tb-rel-c-esr45-m64_bld-0000000/build/mozilla/widget/cocoa/nsChildView.mm:987:11: error: no viable overloaded '='
  mBounds = nsCocoaUtils::CocoaRectToGeckoRectDevPix(frame, newScale);
  ~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dist/include/mozilla/gfx/Rect.h:80:8: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from 'IntRectTyped<mozilla::LayoutDevicePixel>' to 'const IntRectTyped<mozilla::gfx::UnknownUnits>' for 1st argument
struct IntRectTyped :
       ^
../../dist/include/mozilla/gfx/Rect.h:80:8: note: candidate function (the implicit move assignment operator) not viable: no known conversion from 'IntRectTyped<mozilla::LayoutDevicePixel>' to 'IntRectTyped<mozilla::gfx::UnknownUnits>' for 1st argument
struct IntRectTyped :
       ^
/builds/slave/tb-rel-c-esr45-m64_bld-0000000/build/mozilla/widget/cocoa/nsChildView.mm:3598:10: warning: 'NSView' may not respond to 'viewDidChangeBackingProperties'
  [super viewDidChangeBackingProperties];
   ~~~~~ ^
1 warning and 1 error generated.
make[6]: *** [nsChildView.o] Error 1
make[6]: *** Waiting for unfinished jobs....

build 2 failed due to issues with 1262760 bug 1262760 This patch had to be backed out. Build 3 was started but release runner failed with issues related to ssh key rotation. Callek backed out this change and a build3 was able to be started.

build3 - failed at repack_7/10 on win32 update verify failures, investigating bug 1271806

5:14 PM <•nthomas> I think we need to add 38.8.0 to the past-update lines, otherwise it'll be untested
5:15 PM <•kmoir> so how do I do that
5:15 PM <•nthomas> we'll need a block like http://hg.mozilla.org/build/tools/file/default/release/patcher-configs/mozEsr45-thunderbird-branch-patcher2.cfg#l1034 but for 38.8.0, and a line like http://hg.mozilla.org/build/tools/file/default/release/patcher-configs/mozEsr45-thunderbird-branch-patcher2.cfg#l91 added
5:15 PM <•nthomas> then regenerate the update verify configs
5:16 PM <•nthomas> I think I have the perl deps already, so I could do this
5:16 PM <•kmoir> okay I have done that before let me go do that
5:16 PM <•nthomas> end of your day and all
5:16 PM <•kmoir> oh
5:16 PM <•kmoir> oh okay
5:16 PM <•kmoir> I didn't know there was perl magic to fix this :-)
5:17 PM <•kmoir> i'm in Toronto this week so my end of day is more flexible 
5:18 PM <•nthomas> happy to help, just let me know how I can
5:19 PM <•nthomas> rail: np, we could RETRY, would be nice to know why we get these upload hangs too
5:31 PM <•kmoir> nthomas: I'm not sure how to generate a block like this http://hg.mozilla.org/build/tools/file/default/release/patcher-configs/mozEsr45-thunderbird-branch-patcher2.cfg#l1034 
5:32 PM <•kmoir> nthomas: last time I did something like this was https://wiki.mozilla.org/Thunderbird-45.0/BuildNotes
5:34 PM <•nthomas> kmoir: it's pretty safe to just copy <3.7.2> and replace all 3.7.2 with 3.8.0, check the buildN, and update the buildID
5:34 PM <•kmoir> okay
5:35 PM <•nthomas> with buildID from http://archive.mozilla.org/pub/thunderbird/candidates/38.8.0-candidates/build1/win32_info.txt and friends
5:35 PM <•nthomas> should all be the same, but worth checking
5:35 PM <•nthomas> yeah, all 20160503054940
7:11 PM <•nthomas> kmoir: I think you'll need to move THUNDERBIRD_45_1_0_{BUILD3,RELEASE}_RUNTIME to the tip for the verify job to pick it up
7:13 PM <•nthomas> and balrog will need adjusting
7:13 PM <•nthomas> there's a rule limiting 45.1.0 to >45.0 
  • Update rate for 38 and 45 release rules have been set to 10 and pointed to thunderbird 45.1.0 build3