FirefoxOS/Comms/Dialer/Sprint/v2.2-S8
From MozillaWiki
Contents
Bugs
Status
File:Dialer v2.2-S8 burndown chart.png
- <POINTS>,0,0,0,0,0,0,0,0,0
Bugs Taken in Planning
ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
1011066 | Tamara Hills [:thills] | [RTL][Lockscreen] Arabic: Overlapping and truncation caller ID name and "phone" icon. | 2.2+ | No cf_feature-b2g | [planned-sprint c=1] | VERIFIED | FIXED |
1135044 | Gabriele Svelto [:gsvelto] | Call information gets never updated after creating a contact | 2.2+ | No cf_feature-b2g | [planned-sprint c=3] | VERIFIED | FIXED |
1135063 | Gabriele Svelto [:gsvelto] | The "Select logs to delete" button can be used on the Call info page | 2.2+ | No cf_feature-b2g | [planned-sprint c=1] | VERIFIED | FIXED |
1136664 | Doug Sherk (:drs) (inactive) | [Call log] Phone type is not set back to "unknown" if you delete a contact | 2.2+ | No cf_feature-b2g | [planned-sprint c=3] | VERIFIED | FIXED |
1139207 | Oleg Zasypkin [:azasypkin] | [RTL] 'Call Log' truncates long contacts' name at the beginning of the name. | 2.2+ | No cf_feature-b2g | [3.0-Daily-Testing][planned-sprint c=3] | VERIFIED | FIXED |
1139788 | Tamara Hills [:thills] | [RTL][Dialer]The incoming call icon is not left-aligned. | 2.2+ | No cf_feature-b2g | [2.2-nexus-5-l][planned-sprint c=1] | VERIFIED | FIXED |
1141578 | Gabriele Svelto [:gsvelto] | Recent contact's name disappears if you call him back with the call log the first time you start the dialer | 2.2+ | No cf_feature-b2g | [planned-sprint c=3] | VERIFIED | FIXED |
7 Total; 0 Open (0%); 0 Resolved (0%); 7 Verified (100%);
- Does not include Bugs Taken but not Completed.
Bugs Taken but not Completed
No results.
0 Total; 0 Open (0%); 0 Resolved (0%); 0 Verified (0%);
Bugs Taken During Sprint
No results.
0 Total; 0 Open (0%); 0 Resolved (0%); 0 Verified (0%);
All Issues for this Sprint
ID | Assigned to | Summary | Blocking b2g | Feature b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
1011066 | Tamara Hills [:thills] | [RTL][Lockscreen] Arabic: Overlapping and truncation caller ID name and "phone" icon. | 2.2+ | --- | [planned-sprint c=1] | VERIFIED | FIXED |
1135044 | Gabriele Svelto [:gsvelto] | Call information gets never updated after creating a contact | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
1135063 | Gabriele Svelto [:gsvelto] | The "Select logs to delete" button can be used on the Call info page | 2.2+ | --- | [planned-sprint c=1] | VERIFIED | FIXED |
1136664 | Doug Sherk (:drs) (inactive) | [Call log] Phone type is not set back to "unknown" if you delete a contact | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
1139207 | Oleg Zasypkin [:azasypkin] | [RTL] 'Call Log' truncates long contacts' name at the beginning of the name. | 2.2+ | --- | [3.0-Daily-Testing][planned-sprint c=3] | VERIFIED | FIXED |
1139788 | Tamara Hills [:thills] | [RTL][Dialer]The incoming call icon is not left-aligned. | 2.2+ | --- | [2.2-nexus-5-l][planned-sprint c=1] | VERIFIED | FIXED |
1141578 | Gabriele Svelto [:gsvelto] | Recent contact's name disappears if you call him back with the call log the first time you start the dialer | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
7 Total; 0 Open (0%); 0 Resolved (0%); 7 Verified (100%);
- Does not include Bugs Taken but not Completed.
Bugs Redirected
ID | Assigned to | Summary | Blocking b2g | Feature b2g | Whiteboard | Status | Resolution |
---|---|---|---|---|---|---|---|
1011066 | Tamara Hills [:thills] | [RTL][Lockscreen] Arabic: Overlapping and truncation caller ID name and "phone" icon. | 2.2+ | --- | [planned-sprint c=1] | VERIFIED | FIXED |
1135044 | Gabriele Svelto [:gsvelto] | Call information gets never updated after creating a contact | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
1135063 | Gabriele Svelto [:gsvelto] | The "Select logs to delete" button can be used on the Call info page | 2.2+ | --- | [planned-sprint c=1] | VERIFIED | FIXED |
1136664 | Doug Sherk (:drs) (inactive) | [Call log] Phone type is not set back to "unknown" if you delete a contact | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
1139207 | Oleg Zasypkin [:azasypkin] | [RTL] 'Call Log' truncates long contacts' name at the beginning of the name. | 2.2+ | --- | [3.0-Daily-Testing][planned-sprint c=3] | VERIFIED | FIXED |
1139788 | Tamara Hills [:thills] | [RTL][Dialer]The incoming call icon is not left-aligned. | 2.2+ | --- | [2.2-nexus-5-l][planned-sprint c=1] | VERIFIED | FIXED |
1141578 | Gabriele Svelto [:gsvelto] | Recent contact's name disappears if you call him back with the call log the first time you start the dialer | 2.2+ | --- | [planned-sprint c=3] | VERIFIED | FIXED |
7 Total; 0 Open (0%); 0 Resolved (0%); 7 Verified (100%);
Daily Standup Meetings
- Current hosts: drs, gtorodelvalle, thills
- Hosts rotate every week.
- If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
- Start by pinging everyone who should be participating.
- List any administrative items you have, and then ask for more from other people (look at the Etherpad).
- Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
- Move to individual updates. Go alphabetically, in descending order.
- If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
- Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
- Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.
Day 10:
Firefox OS/Comms/Dialer/Sprint/v2.2-S8/20140320-StandupNotes
Day 9:
drs
- Admin:
- Nothing new.
- Next steps:
- Nothing new.
- Patches:
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Going to work on this.
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Reviews:
- bug 1135044 - Call information gets never updated after creating a contact
- r+
- bug 1098673 - Fix duplicate strings in Dialer and Contacts
- r+
- bug 1135044 - Call information gets never updated after creating a contact
- Other:
- Nothing new.
thills
- Admin - I added a note in drs reviewer checklist about RTL. Please feel free to add on to that.
- bug 1139801 - Put this one for review.
- bug 1131246 - I found another font size issue which I’m working on right now. The patch is adjusting the size of fonts in the conference group details page to be too large.
- bug 1134961 -
- Posted a WIP on this one. Not sure who we are handing this off to though. The remaining work is to fix the comma.
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Uplifted.
- bug 1135067 - Uplifted.
- bug 1011066 - Uplifted.
- bug 1139788 - Landed. Uplift approved.
- Reviews:
jlorenzo
- Absent/no report
gsvelto
- Absent/no report
ythej
- Absent/no report
Day 8:
Firefox OS/Comms/Dialer/Sprint/v2.2-S8/20140318-StandupNotes
Day 7:
drs
- Admin:
- Nothing new.
- Next steps:
- Nothing new.
- Patches:
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Going to work on this.
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Reviews:
- bug 1135044 - Call information gets never updated after creating a contact
- r-
- bug 1135044 - Call information gets never updated after creating a contact
- Other:
- Nothing new.
thills
- Admin - I added a note in drs reviewer checklist about RTL. Please feel free to add on to that.
- bug 1139801 - Waiting for review.
- bug 1131246 - Working on test for this font size issue.
- bug 1134961 - I have a line on fix for this one.
- Posted a WIP on this one. Not sure who we are handing this off to though. The remaining work is to fix the comma.
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Uplifted.
- bug 1135067 - Uplifted.
- bug 1011066 - Uplifted.
- bug 1139788 - Landed. Need to ask for uplift.
- Reviews:
- bug 1136664 - r+
- bug 1135023 - r+
- bug 1135063 - r+
jlorenzo
- Admin:
- None
- Done:
- Nothing to report today
- Next steps:
- Nothing currently planned for the dialer.
gsvelto
- Admin:
- None
- Bugs:
- bug 1135044 - Call information gets never updated after creating a contact
- A patch is ready and undergoing review
- bug 1135063 - The "Select logs to delete" button can be used on the Call info page
- Fixed and landed, waiting for approval to land on v2.2
- bug 1124992 - [Dialer] not need to listen to telephonyCallGroup.onerror but handle promise
- I’ve taken this bug at the request of the RIL team, it’s a minor API cleanup
- bug 1141578 - Recent contact's name disappears if you call him back with the call log the first time you start the dialer
- Fixed, landed and uplifted to v2.2
- bug 1144057 - [Dialer]There is a multiple selection button in call information page.
- Closed as duplicate
- bug 1135044 - Call information gets never updated after creating a contact
- Reviews
- None
ythej
- Absent/no report
Day 6:
drs
- Admin:
- Nothing new.
- Next steps:
- Nothing new.
- Patches:
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Going to work on this.
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Reviews:
- Nothing new.
- Other:
- Nothing new.
thills
- Admin - None
- bug 1139801 - Waiting for review.
- bug 1139788 - Review finished. Will try and land this one today.
- bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
- Got some help from drs on this truncation issue.
- bug 1134961 - I have a line on fix for this one.
- Posted a WIP on this one. Not sure who we are handing this off to though. The remaining work is to fix the comma.
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Uplifted.
- bug 1135067 - Uplifted.
- bug 1011066 - Uplifted.
- Reviews:
- bug 1136664 - r+
- bug 1135023 - r+
jlorenzo
- Admin:
- None
- Done:
- Nothing to report today
- Next steps:
- Nothing currently planned for the dialer.
gsvelto
- Admin:
- None
- Bugs:
- bug 1135063 - The "Select logs to delete" button can be used on the Call info page
- Attached a patch, not a pretty fix though
- bug 1141578 - Recent contact's name disappears if you call him back with the call log the first time you start the dialer
- Fixed, landed and uplifted to v2.2
- bug 1135063 - The "Select logs to delete" button can be used on the Call info page
- Reviews
- bug 1139788 - [RTL][Dialer]The incoming call icon is not left-aligned.
- r+’d
- bug 1139801 - [RTL][Dialer]The sequence of duration time, Phone number, and Call status icon remains the same as that in LTR.
- Reviewed this but didn’t r+ it right away because the elements appear shifted in a way that I’m not sure is correct.
- bug 1139788 - [RTL][Dialer]The incoming call icon is not left-aligned.
ythej
- Absent/no report
Day 5:
drs
- Admin:
- Nothing new.
- Next steps:
- Nothing new.
- Patches:
- bug 1136664 - [Call log] Phone type is not set back to "unknown" if you delete a contact
- Landed.
- bug 1136664 - [Call log] Phone type is not set back to "unknown" if you delete a contact
- Reviews:
- bug 1139207 - [RTL] 'Call Log' truncates long contacts' name at the beginning of the name.
- r+
- bug 1139207 - [RTL] 'Call Log' truncates long contacts' name at the beginning of the name.
- Other:
- bug 1142485 - [l10n] End of call message is not displayed entirely with long localizations
- Unassigned blocker.
- Assigned to Gabriele.
- bug 1142610 - [RTL] [Lockscreen] The carrier name overlaps the SIM slot text when recieiving a call on the lockscreen
- Unassigned blocker.
- Assigned to Doug.
- bug 1142485 - [l10n] End of call message is not displayed entirely with long localizations
thills
- Admin - None
- bug 1139801 - Posted a patch for this today. Got clarification from Delphine on how the conference arrow should work. Fixed that as well in this patch.
- bug 1139788 - reposted this after review to handle case where there is no add’l contact info..
- bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
- Got some help from drs on this truncation issue.
- bug 1134961 - I have a line on fix for this one.
- Posted a WIP on this one. Not sure who we are handing this off to though. The remaining work is to fix the comma.
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Uplifted.
- bug 1135067 - Uplifted.
- bug 1011066 - Uplifted.
- Reviews:
- bug 1136664 - r+
- bug 1135023 - r+
gsvelto
- Admin:
- None
- Bugs:
- bug 1135023 - Recent contact's name disappears if you call him back with the call log
- Fixed, landed and uplifted to v2.2
- bug 1135063 - The "Select logs to delete" button can be used on the Call info page
- Investigating the problem
- bug 1135023 - Recent contact's name disappears if you call him back with the call log
- Reviews
- bug 1139788 - [RTL][Dialer]The incoming call icon is not left-aligned.
- r-’d this because one of the scenarios (no additional contact info) is not properly fixed
- bug 1139788 - [RTL][Dialer]The incoming call icon is not left-aligned.
jlorenzo
- Absent/no report
ythej
- Absent/no report
Day 4:
FirefoxOS/Comms/Dialer/Sprint/v2.2-S8/20140312-StandupNotes
Day 3:
Firefox OS/Comms/Dialer/Sprint/v2.2-S8/20140311-StandupNotes
Day 2:
drs
- Admin:
- Messages people can help us with our blockers.
- Next steps:
- bug 1139310 - [Nexus 5][Dialer]The control button in call out view does not work.
- Going to investigate today.
- bug 1136664 - [Call log] Phone type is not set back to "unknown" if you delete a contact
- Going to work on this.
- bug 1139207 - [RTL] 'Call Log' truncates long contacts' name at the beginning of the name.
- Going to work on this.
- bug 1139310 - [Nexus 5][Dialer]The control button in call out view does not work.
- Patches:
- Nothing new.
- Reviews:
- Nothing new.
- Other:
- bug 1094764 - Implement AudioContext.suspend and friends
- This is landing soon. It’ll help us simplify our code a bit.
- bug 1094764 - Implement AudioContext.suspend and friends
thills
- Admin - None
- bug 1139801 - I am about halfway through this. So far, looks to be just css changes.
- bug 1139788 - Posted a patch for this y’day for gsvelto to review. Note that I also moved the SIM (which was oddly not visible and the same color as the background) to the left side.
- bug 1131246 - Posted a feedback on this one. Will try and get this ready for review.
- Got some help from drs on this truncation issue.
- bug 1134961 - I have a line on fix for this one.
- wrapping in bdi fixes the + direction in rtl.
- Still need to fix the comma on the localization of the comma today.
- Bug
- Uplifts:
- bug 1102344 - Uplifted.
- bug 1118422 - Uplifted.
- bug 1126379 - Uplifted.
- bug 1126850 - Uplifted.
- bug 1106175 - Uplifted.
- bug 1131631 - Uplifted.
- bug 1126374 - Uplifted.
- bug 1126368 - Uplifted.
- bug 1132914 - Uplifted.
- bug 1135067 - Uplifted.
- bug 1011066 - Landed. Requested uplift.
- Reviews:
- bug 1134871 - Finished this review - r+
- bug 1131261 - Finished this review - r+ with some minor comments.
- bug 1135023 - Finished this review - r+.
gsvelto
- Admin:
- After quite a bit of testing I’ve come to the conclusion that the emulator-x86-kk is still not good enough for daily work, let alone for integration tests
- Bugs:
- bug 1135023 - Recent contact's name disappears if you call him back with the call log
- I’m trying to figure out what’s still wrong with this bug
- bug 1135023 - Recent contact's name disappears if you call him back with the call log
- Reviews
- None
jlorenzo
- Absent/no report
ythej
- Absent/no report
Day 1:
Firefox OS/Comms/Dialer/Sprint/v2.2-S8/20140309-StandupNotes
PTO
Acquire from Estimates Etherpad
Office Hours
Day 7
- <thills> spend few minutes talking about updating review checklist for rtl.
- https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Design_Patterns_and_Guidelines#Reviewer_Checklist
- <gsvelto> Give icons their own elements.
- <drs> Talk with Wilson about making phone number field a WC.
- <gsvelto> discuss our plans for v3, here's a few ideas
- We know there will be an increased focus on making things modular so we could try turning some pieces of the dialer into proper web components (the keypad for example), or use some existing ones (overlays, buttons, etc...).
- <jlorenzo> DTMF tones: Long pressing 1, then 2 without lifting 1, causes 2 to stop the tone for 1 and continue as 2 until either 1 or 2 are released. Pressing 3 at this point makes the 3 tone play, and then releasing either 1 or 3 causes the tone to stop.
- Startup performance is still high on the priority list and personally I haven't checked it in a while. We should consider it an area where we could imrpove things.
- https://bugzil.la/1144537 — NEW, nobody@mozilla.org — When a contact changes try to update only the relevant call log entries
- We could decide to shed some tech baggage in the existing code. We don't know if the dialer will undergo a big redesign or not but even if it does being able to reuse more of the existing code would help. Most of the stuff we have now works fairly well but is too fragile to reuse.
- We know there will be an increased focus on making things modular so we could try turning some pieces of the dialer into proper web components (the keypad for example), or use some existing ones (overlays, buttons, etc...).