Firefox OS/Comms/Dialer/Sprint/v2.1-S3

From MozillaWiki
Jump to: navigation, search

Bugs

Status

Dialer v2.1-S3 burndown chart.png

  • 38,39,31,26,29,28,28,31,29,10

Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
877971 Anthony Ricaud (:rik) The call logs menu doesn't show the call time duration --- No cf_feature-b2g [tef-triage][planned-sprint][2.1-feature-qa+] VERIFIED FIXED
1026692 Tamara Hills [:thills] Access to mute button --- No cf_feature-b2g [tako][planned-sprint c=6][2.1-feature-qa+][in-sprint=v2.1-S2] VERIFIED FIXED
1035763 Tamara Hills [:thills] [B2G][Dialer] support 24 hour time format --- No cf_feature-b2g [planned-sprint c=6] VERIFIED FIXED
1037066 Doug Sherk (:drs) (inactive) [Dialer] Keypad background color changes are delayed --- No cf_feature-b2g [c=effect p= s=2014.08.15.t u=] [planned-sprint] RESOLVED FIXED
1038701 Doug Sherk (:drs) (inactive) [US] Support for ICE Contacts in Lockscreen/Emergency call --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] VERIFIED FIXED
1045499 Doug Sherk (:drs) (inactive) Switch call log to a 2-line layout --- No cf_feature-b2g [planned-sprint c=3][in-sprint=v2.1-S2] RESOLVED FIXED
1047353 Anthony Ricaud (:rik) Create a call information page for call log --- No cf_feature-b2g [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1047356 Anthony Ricaud (:rik) Modify the call log user interface to link to the call information page --- No cf_feature-b2g [planned-sprint c=][in-sprint=v2.1-S2] RESOLVED FIXED
1054995 Doug Sherk (:drs) (inactive) Share the way to display phone, sms and email information. --- No cf_feature-b2g [planned-sprint c=6] RESOLVED FIXED
1059336 Doug Sherk (:drs) (inactive) Add bindings for contact buttons in the call information page --- No cf_feature-b2g [planned-sprint c=3] RESOLVED FIXED

10 Total; 0 Open (0%); 6 Resolved (60%); 4 Verified (40%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
943389 [Dialer][Conference call] Detailed contact info on conference call on group line is missing --- No cf_feature-b2g [planned-sprint][in-sprint=v2.1-S3] RESOLVED WONTFIX
1029313 [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing --- No cf_feature-b2g [planned-sprint][in-sprint=v2.1-S3] RESOLVED WONTFIX
1030631 Jorge Prudencio [:jorgep] [Dialer] Text not aligned when matches are more than 1 if contact has long name --- No cf_feature-b2g [priority][planned-sprint][in-sprint=v2.1-S3] RESOLVED FIXED
1038846 Jorge Prudencio [:jorgep] [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message 2.0M+ No cf_feature-b2g [planned-sprint][in-sprint=v2.1-S3] RESOLVED FIXED

4 Total; 0 Open (0%); 4 Resolved (100%); 0 Verified (0%);

Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1037047 Yura Zenevich [:yzen] (please use "needinfo") [B2G][Dialer] Using screenreader on dialer screen during an active call results in major graphical issues --- No cf_feature-b2g [273MB-Flame-Support],[2.0-exploratory],[b2ga11y p=1] RESOLVED FIXED
1041903 Michael Henretty [:mikehenrty][:mhenretty] [Dialer] Customize Status Bar Color --- No cf_feature-b2g [systemsfe] RESOLVED FIXED
1048458 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) [B2G][2.1][Dialer] Calling a second number while another call is in progress cover's touchpad in Dialer app 2.1+ No cf_feature-b2g VERIFIED FIXED
1050748 Jorge Prudencio [:jorgep] [l10n] Cancel button is not localized when displaying matches from contacts in Dialer --- No cf_feature-b2g RESOLVED DUPLICATE
1054185 Doug Sherk (:drs) (inactive) "Default" is missing from SIM picker 2.1+ No cf_feature-b2g VERIFIED FIXED
1056883 Doug Sherk (:drs) (inactive) Single call contact info is clipped due to distance to addl. clipping being too small --- No cf_feature-b2g RESOLVED FIXED
1059108 Etienne Segonzac (:etienne) Intermittent calls_handler_test.js,handled_call_test.js | Timed out after 120 seconds --- No cf_feature-b2g RESOLVED FIXED
1060801 Doug Sherk (:drs) (inactive) Rename "Cancelled" to "Canceled" in call info view --- No cf_feature-b2g RESOLVED FIXED

8 Total; 0 Open (0%); 6 Resolved (75%); 2 Verified (25%);

All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
877971 Anthony Ricaud (:rik) The call logs menu doesn't show the call time duration --- 2.1 [tef-triage][planned-sprint][2.1-feature-qa+] VERIFIED FIXED
1026692 Tamara Hills [:thills] Access to mute button --- 2.1 [tako][planned-sprint c=6][2.1-feature-qa+][in-sprint=v2.1-S2] VERIFIED FIXED
1035763 Tamara Hills [:thills] [B2G][Dialer] support 24 hour time format --- 2.1 [planned-sprint c=6] VERIFIED FIXED
1037047 Yura Zenevich [:yzen] (please use "needinfo") [B2G][Dialer] Using screenreader on dialer screen during an active call results in major graphical issues --- --- [273MB-Flame-Support],[2.0-exploratory],[b2ga11y p=1] RESOLVED FIXED
1037066 Doug Sherk (:drs) (inactive) [Dialer] Keypad background color changes are delayed --- --- [c=effect p= s=2014.08.15.t u=] [planned-sprint] RESOLVED FIXED
1038701 Doug Sherk (:drs) (inactive) [US] Support for ICE Contacts in Lockscreen/Emergency call --- 2.1 [planned-sprint c=3][in-sprint=v2.1-S2] VERIFIED FIXED
1041903 Michael Henretty [:mikehenrty][:mhenretty] [Dialer] Customize Status Bar Color --- --- [systemsfe] RESOLVED FIXED
1045499 Doug Sherk (:drs) (inactive) Switch call log to a 2-line layout --- 2.1 [planned-sprint c=3][in-sprint=v2.1-S2] RESOLVED FIXED
1047353 Anthony Ricaud (:rik) Create a call information page for call log --- 2.1 [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1047356 Anthony Ricaud (:rik) Modify the call log user interface to link to the call information page --- --- [planned-sprint c=][in-sprint=v2.1-S2] RESOLVED FIXED
1048458 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) [B2G][2.1][Dialer] Calling a second number while another call is in progress cover's touchpad in Dialer app 2.1+ --- VERIFIED FIXED
1050748 Jorge Prudencio [:jorgep] [l10n] Cancel button is not localized when displaying matches from contacts in Dialer --- --- RESOLVED DUPLICATE
1054185 Doug Sherk (:drs) (inactive) "Default" is missing from SIM picker 2.1+ --- VERIFIED FIXED
1054995 Doug Sherk (:drs) (inactive) Share the way to display phone, sms and email information. --- --- [planned-sprint c=6] RESOLVED FIXED
1056883 Doug Sherk (:drs) (inactive) Single call contact info is clipped due to distance to addl. clipping being too small --- --- RESOLVED FIXED
1059108 Etienne Segonzac (:etienne) Intermittent calls_handler_test.js,handled_call_test.js | Timed out after 120 seconds --- --- RESOLVED FIXED
1059336 Doug Sherk (:drs) (inactive) Add bindings for contact buttons in the call information page --- --- [planned-sprint c=3] RESOLVED FIXED
1060801 Doug Sherk (:drs) (inactive) Rename "Cancelled" to "Canceled" in call info view --- --- RESOLVED FIXED

18 Total; 0 Open (0%); 12 Resolved (66.67%); 6 Verified (33.33%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
877971 Anthony Ricaud (:rik) The call logs menu doesn't show the call time duration --- 2.1 [tef-triage][planned-sprint][2.1-feature-qa+] VERIFIED FIXED
1026692 Tamara Hills [:thills] Access to mute button --- 2.1 [tako][planned-sprint c=6][2.1-feature-qa+][in-sprint=v2.1-S2] VERIFIED FIXED
1035763 Tamara Hills [:thills] [B2G][Dialer] support 24 hour time format --- 2.1 [planned-sprint c=6] VERIFIED FIXED
1037066 Doug Sherk (:drs) (inactive) [Dialer] Keypad background color changes are delayed --- --- [c=effect p= s=2014.08.15.t u=] [planned-sprint] RESOLVED FIXED
1038701 Doug Sherk (:drs) (inactive) [US] Support for ICE Contacts in Lockscreen/Emergency call --- 2.1 [planned-sprint c=3][in-sprint=v2.1-S2] VERIFIED FIXED
1045499 Doug Sherk (:drs) (inactive) Switch call log to a 2-line layout --- 2.1 [planned-sprint c=3][in-sprint=v2.1-S2] RESOLVED FIXED
1047353 Anthony Ricaud (:rik) Create a call information page for call log --- 2.1 [planned-sprint c=6][in-sprint=v2.1-S2] RESOLVED FIXED
1047356 Anthony Ricaud (:rik) Modify the call log user interface to link to the call information page --- --- [planned-sprint c=][in-sprint=v2.1-S2] RESOLVED FIXED
1054995 Doug Sherk (:drs) (inactive) Share the way to display phone, sms and email information. --- --- [planned-sprint c=6] RESOLVED FIXED
1057619 Doug Sherk (:drs) (inactive) Node definition in fb_tel_index.js conflicts with browser's Node web API 2.0+ --- [planned-sprint] RESOLVED FIXED
1059336 Doug Sherk (:drs) (inactive) Add bindings for contact buttons in the call information page --- --- [planned-sprint c=3] RESOLVED FIXED

11 Total; 0 Open (0%); 7 Resolved (63.64%); 4 Verified (36.36%);


Daily Standup Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: September 1

drs

  • Admin:
    • Nice work everyone! We got all of our 2.1 feature work done on time.
    • Did planning for 2.1 S4.
    • Filed a ton of followups for this sprint.
  • Next steps:
    • Sprint planning needed.
    • Need to do my demos.
  • Done:
    • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call
      • Taken and landed.
    • bug 1059336 - Add bindings for contact buttons in the call information page
      • Landed.
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Review+ for Tamara, landed.
    • bug 1047353 - Create a call information page for call log
      • Review+ for Anthony, landed.
    • bug 1047356 - Modify the call log user interface to link to the call information page
      • Review+ for Anthony, landed.

Rik

  • Admin:
  • Update:
  • Landed all the features! Wow ooooow. Friday was a bit intense :)
  • Today is about filing followups, cleaning some tasks that have been delayed, reviews and needinfos. Basically getting ready to start a new cycle.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

thills

  • Absent/no report

Day 9: August 29

drs

  • Admin:
    • We must land all 2.1 features today.
    • Do a quick poll to see if Tuesday is ok for sprint planning.
  • Next steps:
    • bug 1059336 - Add bindings for contact buttons in the call information page
      • This is my top priority. I posted a small patch for Francisco to review to change some shared code in contacts. The main patch is functionally done but I have to add tests.
    • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call
      • No work here yet, but keeping an eye on this as I may have to take it. Once Anthony gives review comments, I will fix them up as I doubt we can rely on Germán to do work while he's on PTO.
  • Done:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • Landed.
    • bug 1057619 - Node definition in fb_tel_index.js conflicts with browser's Node web API
      • Landed.
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Review- for Tamara. This is getting there and we're going to land it today.
    • bug 1047353 - Create a call information page for call log
      • Review- for Anthony.

thills

  • bug 1035763 - Support 24 hour time format
    • Finished call log tests
    • Finished latest round of review from drs
    • Working on rebasing
      • <drs> Friday is fine as well. Let's make sure it doesn't go later than that, though.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
  • bug 1058312 - [Contacts] Individual Contact Field "Company" cannot be removed after being updated
    • Patch made. Waiting to review.
  • bug 1030564 - [Contacts][DSDS] SIM label flashing once when tapping on "Add as favorite" and "Remove as favorite"
    • Patch made. Waiting to review.
  • bug 836690 - [SMS] Implement temporary in App message informing the user that they have started another SMS packet
    • Waiting to Carrie UX review.
  • bug 986034 - [Contacts] In contact, drag and press "search" button doesn't work
    • Patch made. Waiting to review.

Rik

  • Helping Gaia open again
  • Trying to understand the impact of bug 1022767. I feel we should back it out, it's an ongoing discussion
  • Working on bug 1047356 review comments. Will post the patch just after the meeting
  • Will address review comments for bug 1047353 after that with the hope of landing it today.

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

Day 8: August 28

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • I posted a new patch today with some small changes, additional tests. There are still tests failing everywhere so I have a bit of work to do.
    • bug 1059336 - Add bindings for contact buttons in the call information page
      • With bug 1054995 in review, I'm now adding the bindings to the call information page. This is my second top priority. I posted a WIP which needs some tests, small fixes, and more progress on bug 1047353.
    • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call
      • No work here yet, but keeping an eye on this as I may have to take it. If Germán doesn't give an update by after today's standup, I'm going to take it.
  • Done:
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Feedback+/review- for Tamara. This is getting there and I think we can land it today.
    • bug 1047353 - Create a call information page for call log
      • Feedback+ for Anthony.
    • bug 1059108 - Intermittent calls_handler_test.js,handled_call_test.js | Timed out after 120 seconds
      • Review+ for Etienne.
    • bug 1037047 - [B2G][Dialer] Using screenreader on dialer screen during an active call results in major graphical issues
      • Review+ for Yura.
  • Other:
    • bug 848954 - Call the MediaStreamGraph's processing code from the cubeb callback when needed
      • Mention only. Paul landed this, might be useful for some of Gabriele's and David's work regarding DTMF tones.

Rik

  • bug 1059108 - very intermittent, almost red unit tests
  • Full steam on bug 1047353 - Create a call information page for call log. I'm currently working on the tests. Got a first light f+ from Doug
  • Reviews

thills

  • bug 1035763 - Support 24 hour time format
    • Finished changes to utils.js to reuse existing Mockl10n.js
    • Finished adding a test to callscreen.
    • Remaining task: call_log tests (started, but still working on it)
    • Remaining task: removing utils.js from the lint failure list.
    • Targeting having this done by Thurs since it's part of the 2.1 FL
      • <drs> Friday is fine as well. Let's make sure it doesn't go later than that, though.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
  • bug 1058312 - [Contacts] Individual Contact Field "Company" cannot be removed after being updated
    • Patch made. Waiting to review.
  • bug 1030564 - [Contacts][DSDS] SIM label flashing once when tapping on "Add as favorite" and "Remove as favorite"
    • Patch made. Waiting to review.
  • bug 836690 - [SMS] Implement temporary in App message informing the user that they have started another SMS packet
    • Waiting to Carrie UX review.
  • <drs> Hi Jorge. I'm not sure if you saw, but we're prioritizing 2.1 features for now, so our review backlog has gotten pretty big. Sorry that we haven't been able to review a lot of your work. We'll get right on it after 2.1 feature landing (Tuesday).
  • <jpruden92> Hi <drs>. Ok, I understand that there are priorities ;-)

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

Day 7: August 27

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • Completely focused on this, posted a patch for Francisco to review.
    • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call
      • No work here yet, but keeping an eye on this as I may have to take it.
  • Done:
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Feedback+/review- for Tamara.

Rik

  • Doctor's appointment later today
  • Full steam on bug 1047353 - Create a call information page for call log. I'm currently working on the tests.
  • Following <gaia-header> landing bug 1011601, currently blocked on an accessibility issue : bug 887541
  • Reviews

thills

  • bug 1035763 - Support 24 hour time format
    • Finished with first round of feedback. Put another feedback up and started working through drs feedback from this.
    • finished initial round of tests. Have a feedback in for this.
    • Targeting having this done by Thurs since it's part of the 2.1 FL
      • <drs> Friday is fine as well. Let's make sure it doesn't go later than that, though.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
  • bug 1058312 - [Contacts] Individual Contact Field "Company" cannot be removed after being updated
    • Patch made. Waiting to review.
  • bug 1030564 - [Contacts][DSDS] SIM label flashing once when tapping on "Add as favorite" and "Remove as favorite"
    • Patch made. Waiting to review.

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

Day 6: August 26

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • Will have a patch today.
  • Done:
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Feedback+/review- for Tamara.
    • bug 1054185 - "Default" is missing from SIM picker
      • Landed.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Wrote up a Gaia patch, posted for Anthony to review.

Rik

  • I injured my arm this morning and thought I wouldn't be able to work for a couple of days. But I'm way better now
  • Full steam on bug 1047353 - Create a call information page for call log
  • If you have 2.1 features blocked by me, please ping me. I'm focusing on my bugs in the mean time.
  • Reviews

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • 100% focused on implementing the comments received from Anthony

thills

  • bug 1035763 - Support 24 hour time format
    • Working through the feedback from drs and rik on this. I may have a few more questions.
    • I am also working on the tests for this.
    • Targeting having this done by Thurs since it's part of the 2.1 FL

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • <gtorodelvalle> feedback+.
    • Waiting to review.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
  • bug 1058312 - [Contacts] Individual Contact Field "Company" cannot be removed after being updated
    • Patch made. Waiting to review.

pacorampas

  • Absent/no report

Day 5: August 25

drs

  • Admin:
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • This is my top priority now.
    • bug 1035763 - [B2G][Dialer] support 24 hour time format
      • Reviewing this for Tamara before and after the standup.
    • bug 1054185 - "Default" is missing from SIM picker
      • Got review- from Anthony. Have to put up a new version of this.
  • Done:
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • Unfortunately, I had to back this out. I'll come back to it in v2.1-S4.
    • bug 1011601 - [Dialer] Update to use <gaia-header>
      • We got into a bit of an argument over UX here. I think it's resolved now, but Anthony still has to review it.
    • bug 1057005 - [gaia-header][gaia-theme] Unwanted transitions between button states
      • Splintered from bug 1011601. I posted some videos here demonstrating what I was talking about.
    • bug 1056883 - Single call contact info is clipped due to distance to addl. clipping being too small
      • Landed.
    • bug 1050748 - [l10n] Cancel button is not localized when displaying matches from contacts in Dialer
      • When reviewing this, Zibi and I realized that there's a deeper issue, so we investigated this and filed bug 1057619.
    • bug 1057619 - Node definition in fb_tel_index.js conflicts with browser's Node web API
      • Posted a patch for review from Jose.
    • bug 1047356 - Modify the call log user interface to link to the call information page
      • Review- for Anthony again.

gtorodelvalle

  • Administrative:
    • Nothing to report
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
  • bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
    • Helping Paco with the unit tests.
    • We'll ask for review ASAP :)

thills

  • bug 1035763 - Support 24 hour time format
    • Have a WIP for feedback.
    • Looking at an alternate approach for modifying the times that might be more maintainable if I can get it to work.

jpruden92

  • <drs> Please make sure to set the target milestone when you begin working on a bug. I know there's a lot of stuff to remember to set, but I really appreciate it when you do this. It makes tracking things a lot easier.
  • <jpruden92> Done, I have added millestone to my bugs.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Waiting to <gtorodelvalle> feedback.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
    • Patch made. Waiting to review.
  • bug 1050748 - [l10n] Cancel button is not localized when displaying matches from contacts in Dialer

Rik

  • Absent/no report

pacorampas

  • Absent/no report

Day 4: August 22

drs

  • Admin:
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • This is my top priority now.
    • bug 1054185 - "Default" is missing from SIM picker
      • Got review- from Anthony. Have to put up a new version of this.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • This has blown up in our faces a bit and caused bug 1055214 and bug 1049250. I'm going to investigate this if I have time, but otherwise punt this to after FL.
      • Add bug 1055203 to the list.
  • Done:
    • bug 1011601 - [Dialer] Update to use <gaia-header>
      • Review+ for Yan, redirected feedback? to Anthony since I stole this review from him.
      • Now that the button[disabled] selector was uplifted, there's a new problem with a transition for the "delete" button in the call log edit mode which looks out of place. I requested a followup be filed, bug 1057005, but I don't like where the discussion is going. If we don't remove the transition from the gaia-header WC, I'm going to request an override to disable it within the dialer before it gets landed.
    • bug 1056883 - Single call contact info is clipped due to distance to addl. clipping being too small
      • Posted a patch for Anthony to review, got ui-review+ from Carol.
    • bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
      • I wrote up a quick Gecko patch for this, but then I looked further and found that there's an "onmoztimechange" event fired on the window element which does a better job at what I was adding. This doesn't have blocking/feature status though, so I'm not going to keep working on this until after FL.
    • bug 1047356 - Modify the call log user interface to link to the call information page
      • Review- for Anthony again.
    • bug 1045499 - Switch call log to a 2-line layout
      • Landed. Filed a followup as well to remove the contact log images.

Rik

  • Responded to the dev.gaia thread about Smoketests for Dialer.
  • bug 1056535 was a new blocker but in the end, it's a RIL issue so nothing to do for us
  • Looked at another batch of ~50 bugs in my watched component queue.
  • Made good progress on bug 1047353. Close to functionally complete, I'll have testing and styling to work on after.

gtorodelvalle

thills

  • bug 1026692 - Access to mute button
    • Addressed Anthony's comments and have r+.
    • Have r+ from Carol.
    • Flagged with checkin-needed
  • bug 1035763 - Support 24 hour time format
    • Have a WIP for feedback.
    • Looking at an alternate approach for modifying the times that might be more maintainable if I can get it to work.

jpruden92

  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Resolving some problems.
    • Waiting to <gtorodelvalle> feedback.
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Patch made. Waiting to review.
  • bug 1050748 - [l10n] Cancel button is not localized when displaying matches from contacts in Dialer
    • Patch made. Waiting to review.

pacorampas

  • Absent/no report

Day 3: August 21

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • bug 1054185 - "Default" is missing from SIM picker
      • Got review- from Anthony. Have to put up a new version of this.
    • bug 1054995 - Share the way to display phone, sms and email information.
      • This is my top priority now.
    • bug 1037066 - [Dialer] Keypad background color changes are delayed
      • This has blown up in our faces a bit and caused bug 1055214 and bug 1049250. I'm going to investigate this if I have time, but otherwise punt this to after FL.
  • Done:
    • bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
      • Moved this back to Germán as I misunderstood his PTO.
    • bug 1011601 - [Dialer] Update to use <gaia-header>
      • Review- for Yan. We did a lot of review over IRC. He's waiting for the uplift of a button[disabled] selector for the gaia-header web component and then it'll be ready.
    • bug 1047356 - Modify the call log user interface to link to the call information page
      • Review- for Anthony.
    • bug 1030366 - Hidden toolbar is not really hidden when editing contact
      • Review+ for Yura.
    • bug 1045499 - Switch call log to a 2-line layout
      • Got review+ from Anthony. Waiting for ui-review from Carrie before I land it.

Rik

  • bug 1039854 is probably gonna be a blocker. I looked into it and it seems to be a build issue. Lost some time on a bricked Hamachi
  • "Modify the call log user interface to link to the call information page" - bug 1047356 is basically done and going through a second review round.
  • Started on bug 1047353.

gtorodelvalle

  • Administrative:
    • Nothing to report
  • Loop:
    • Provided feedback and mentoring to Loop guys regarding tone playing related to call status (dialing, busy, hang up, etc.) since they have to play in the client tones which in our case the RIL takes care of.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • We found an issue related to the new CSS linter when trying to commit some changes in this patch (https://github.com/jpruden92/gaia/compare/bug943389-dialer-v2):
      • git commit -m "Test"
      • jshint check:
      • 0 errors
      • There were errors while linting the files, please see above.
    • We also ran |make csslint| but only found already existent warnings and an error but on a file not updated in the proposed patch.
    • After discussing with Anthony, it was caused by bug 1029385 which was reverted ;)
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • I'll focus on this bug tomorrow to implement Anthony's comments ;)

pacorampas

  • Absent/no report

thills

  • Absent/no report

jpruden92

  • Absent/no report

Day 2: August 20

drs

  • Admin:
    • I have a meeting with Bhavana on Friday to help with relman stuff. Since Lawrence has left B2G, it will basically be a repeat of my meeting with him, I figure.
    • I talked with Julien about scrummaster responsibilities. See the thread on the fxos-comms@mozilla.com mailing list.
  • Next steps:
    • bug 1054995 - Share the way to display phone, sms and email information.
      • This is my top priority now.
  • Done:
    • bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
      • Going to take and finish this today. Germán already has a patch up which just needs some cleanup.
      • Moving this back to Germán as we misunderstood his PTO.
    • bug 1055510 - Reduce the overpaint of the dialer app - again
      • Review+ for Vivien.
    • bug 1035674 - [Dialer] - check missing images
      • Review+ for Pavel.
    • bug 1011601 - [Dialer] Update to use <gaia-header>
      • Review- for Yan.
    • bug 1054185 - "Default" is missing from SIM picker
      • Investigated, posted a patch. I think we could also dupe this to bug 1045820, but I don't think anyone else would want to do that.
    • bug 1045499 - Switch call log to a 2-line layout
      • Got review-, posted a new patch for Anthony to review.
  • bug 1026692 - Access to mute button
    • Did a mini-review, helped Tamara get this sorted out for posting. I gave some bad advice and it's a bit ugly now. Sorry, Anthony!

Rik

  • I reached 1000 unread mails watching the Dialer component. Went over 50 bugs. I'll do one pomodoro to get this reduced.
  • bug 1047356 - I'm done, I just have to modify the tests. I'm not sure how to test clicking on OptionMenu items. Asked Oleg.
  • Helped jpruden92 find some bugs to work on from dialer-most-wanted.
  • Reviews

gtorodelvalle

  • Administrative:
    • Getting back from my 2 days PTO :)
    • Summer holidays from August, the 27th to September, the 12th (both inclusive)
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • Provided feedback to Jorge on this as well as on unit testing.
  • bug 1038701 - Support for ICE Contacts in Lockscreen/Emergency call:
    • Coordinate with Doug who should work on it ;)
    • <drs> You can take this back if you have time to work on it. But it must be prioritized.
    • <gtorodelvalle> No problem since we have already made much progress. Just deciding on some final issues.
  • bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
    • Discuss with Anthony how to proceed.

thills

  • bug 1026692 - Access to mute button
    • Incorporated some feedback from rik and some addtional feedback from drs.
    • Carrie wants to go without the padding so will make that change
  • bug 1035763 - Support 24 hour time format
    • Started looking at this.

jpruden92

  • <drs> Hi Jorge. Are you on PTO at all during this sprint? Since the Telefonica people are all on PTO, if you need any help with anything, please feel free to contact me or Anthony on IRC or by email. My email is dsherk@mozilla.com
  • <jpruden92> Hi, I'm going to be on Telefonica all the month. I don't going to be on PTO.
  • <drs> Would you like to join us in our daily standups? They're every weekday at 4:30 pm CEST in #fxos-dialer on IRC. Also, do you have work to do right now? We could use a hand.
  • <jpruden92> I have spoken with <Rik> and he have sent me some "first first bugs" to work in them. I can help you if you need.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • ui-review done.
    • unit-test done. Waiting to <gtorodelvalle> feedback.
    • Resolving some problems
  • bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
    • Making a patch.
    • Patch made. Waiting to review.
  • bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
    • Making a patch.
    • Patch made. Waiting to review.

pacorampas

  • Absent/no report

Day 1: August 19

drs

  • Admin:
  • Next steps:
    • bug 1055510 - Reduce the overpaint of the dialer app - again
      • Need to review this for Vivien.
    • bug 1035674 - [Dialer] - check missing images
      • Need to review this for Pavel.
    • bug 1054185 - [Messages][SMS] "Default" is missing Select SIM page when sending messages from call log
      • Need to investigate this for Julien.
    • bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
      • Going to take and finish this today. Germán already has a patch up which just needs some cleanup.
    • bug 1054995 - Share the way to display phone, sms and email information.
      • If I have time, I'll also work on this.
  • Done:
    • Did some work outside the dialer.
    • bug 1045499 - Switch call log to a 2-line layout
      • Put up a new patch with UI changes requested by Carol.
      • Waiting for review from Anthony.

Rik

  • QA blocker in Contacts bug 1053477. Helping with the strategy to solve it.
  • bug 1047356 Link to call information page. I was stupid and didn't notice the code I was cleaning was used somewhere else. So I need to swtich to another method. Lost a lot of time because of this :(
  • Reviews

thills

  • bug 1026692 - Access to mute button
    • I have feedback from rik and have incorporated all of that (Thank you).
    • I received an updated spec from Carol this morning with some additional details. She also has a concern about how it shows up on the larger devices so I included screenshots for that. I'm going to go ahead and make the changes to adjust the horizontal spacing how she wants.

jpruden92

  • <drs> Hi Jorge. Are you on PTO at all during this sprint? Since the Telefonica people are all on PTO, if you need any help with anything, please feel free to contact me or Anthony on IRC or by email. My email is dsherk@mozilla.com
  • <jpruden92> Hi, I'm going to be on Telefonica all the month. I don't going to be on PTO.
  • <drs> Would you like to join us in our daily standups? They're every weekday at 4:30 pm CEST in #fxos-dialer on IRC. Also, do you have work to do right now? We could use a hand.
  • Introducing on unit tests.
  • bug 1050144 - [Dialer] "Call ended" text not vertically centred:
    • Fixed.
  • bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
    • ui-review done.
  • bug 1052370 - [Dialer][Emergency call] Duplicate phone number when typing number:
    • Fixed

gtorodelvalle

  • Absent/no report

pacorampas

  • Absent/no report

PTO

  • davidg: Aug 18 - Aug 22
  • drs: none
  • gsvelto: Aug 25
  • gtorodelvalle: Aug 27 - Aug 29 (+Aug 29 - Sep 12 next sprint)
  • jpruden92: none
  • paco: Aug 18 - Aug 25
  • Rik: none
  • thills: none

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> Though we took on too much, we got a lot done.
  • <Rik> Felt that reviews where not an issue except for today because holiday.

Things we could do better

  • <drs> We took on way too much and didn't complete a lot of it. Even worse, most of what we didn't complete were bugs that were planned.
  • <drs> I think we should count the "all issues in sprint", not the planned bugs. Since they're so intermingled, it's more useful to know if we're taking too much in general, not just in the beginning. Whether or not we finish everything we planned on taking isn't actually super important since there are legitimate reasons, other than being overloaded, that we might not finish them. So I'd rather know if we're overloading ourselves or not, and to me "all bugs" is a better indication of that than "planned bugs".
  • <thills> a small thing, but when we do the estimates, we should probably note down what we actually settle on in the EP... if it's not already noted in the bug.
    • <drs> Ok, I'll add this before I set it on Bugzilla.
  • <thills> I thought the estimation process was good and collaborative. I do think we should require that a bug have points on it before we allow it into the sprint... that just forces us to think about it a little before just assuming that it's a 1.
    • <drs> I'm glad you liked it. Are you suggesting that we estimate bugs and features?
  • <gsvelto> On a personal note, I was swamped with last minute 1.4+ blockers in other areas which prevented me from getting anything done
  • <Rik> A tool to count the bugs count would make it even faster for hosts to update our wiki pages daily

Action items

  • <drs> Begin writing PTO days down so we have a better estimate of how many points of velocity we can take.
  • <drs> Add which issues to look at in hosting standup instructions.
  • <drs> Switch to "all issues" for counting velocity.
  • <drs> Have people who take bugs estimate them.
  • <drs> Tool for counting bugs. Look into https://scrumbu.gs/
  • <drs> Do blog posts for demos on FL instead of every sprint end.

Demos

12 hour time on the call log 24 hour time on the call log 24 hour time on the incoming call

  • bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
(screencast) No ICE contacts or associated phone numbers

(screencast) 1 ICE contact with 3 phone numbers

(screencast) Scrolling of 2 ICE contacts with many phone numbers

(screencast) ICE contacts with airplane on

(screencast) ICE contacts with SIM PIN not inserted (no network)

(screencast) 1 ICE contact with 1 valid phone number

User is not muted User has muted

  • bug 1056883 - Single call contact info is clipped due to distance to addl. clipping being too small

Clipping before and after

Before After

  • bug 877971 - The call logs menu doesn't show the call time duration

Call-info-1.pngCall-info-2.pngCall-info-3.pngCall-info-4.pngCall-info-5.png

Retrieved from "https://wiki.mozilla.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S3&oldid=1052095"