WebDriver/RemoteProtocol/Meetings/2019/04/29
From MozillaWiki
< WebDriver | RemoteProtocol | Meetings(Redirected from Remote/Meetings/2019/04/29)
Agenda
-
Communication issues(yulia) - MVP planning (ato)
- WordPress/Gutenberg tests (bug tree) (alex)
Roster
- Present
- ochameau, AutomatedTester, ato
- Regrets
- yulia, sole
Minutes
- Alex is finally able to run the first Gutenberg test up to completion!
- Had to reverse engineer the precise order of CDP events, which has proven challenging
- ato thinks it makes sense to focus on ensuring it is cross-browser compatible, otherwise end users will find it hard to relate CDP events to web platform primitives and there will be a difference in behaviour between Chrome and Firefox
- Alxo also submitted patches for:
- Implement
Page.frameNavigated
(bug 1543095) - Implement
Runtime.executionContextCreated
andRuntime.executionContextDestroyed
(bug 1543098)- A followup, though not mandatory for WordPress is also to fire
Runtime.executionContextDestroyed
when the tab closes (bug 1547198)
- A followup, though not mandatory for WordPress is also to fire
- Implement
- Other CDP methods to follow up on:
- Implement
Runtime.evaluate
andRuntime.callFunctionOn
(bug 1543099) - Implement
Page.reload
(bug 1544445)
- Implement
- More memory leaks reported for browser-chrome tests
- We disabled browser_cdp.js last week because it was perma-failing the leakcheck, and we thought the memory leak was limied to this one test
- Over the weekend more intermittent leaks cropped up in other tests:
- We will proceed with disabling the browser-chrome tests on debug builds
- We suspect there’s a memory leak related to
nsIServerSocket
, but it’s not a priority to fix it right now - Memory leaks obviously also affect optimised builds, but since we’re not doing refcounting we don’t notice
- Reminder that we will have another meeting tomorrow, at 13:30–14:00 BST/14:30–15:00 CEST
Changelog
% git log --date=iso --pretty=format:'%ad%x09%H' -- remote/ | awk '$0 >= "2019-04-14" && $0 <= "2019-04-29"' | awk -F $'\t' '{print $2}' | xargs git show -s --format='%h%x09%s' 93c3f7445477 bug 1546945: remote: disable browser_cdp.js browser-chrome test on debug; r=ochameau 35402ab61d46 Merge mozilla-central to autoland. a=merge CLOSED TREE 4186ffca24df bug 1546722: remote: print better errors in browser chrome tests; r=yulia 2fc6594fa7a8 bug 1546714: remote: fix bug component mapping for remote/targets/; r=ochameau b1f9999f2407 bug 1546714: remote: map Remote Protocol :: {DOM, Input} bug components; r=ochameau 33d2c887975b bug 1546935: remote: reflect that remote agent is disabled in usage docs; r=me a=doc 5bb63415133b bug 1546933: remote: clarify that tests are run on try; r=me a=doc 85b13ec57a87 bug 1546933: remote: drop unnecessary flags for ./mach test; r=me a=doc 50c097694ba5 Backed out 2 changesets (bug 1546714) for test_mozbuild_reading.py bustages CLOSED TREE cce239e492a7 bug 1546714: remote: fix bug component mapping for remote/targets/; r=ochameau 7d70a14243e9 bug 1546714: remote: map Remote Protocol :: {DOM, Input} bug components; r=ochameau 5078faeecc2c bug 1533831: remote: remove test_FatalError; r=ochameau 4407af360514 bug 1533831: remote: run bc tests as part of regular batch; r=ochameau 2d21b388e10e bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester fcedeac34cb4 bug 1533831: remote: disable remote agent; r=ochameau 672160fa8c69 bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia 1d7ebbeb7b12 Backed out 4 changesets (bug 1533831) for xpcshell failures on remote/test/unit/test_Error.js. CLOSED TREE 32b6b98b87ba bug 1533831: remote: run bc tests as part of regular batch; r=ochameau a87ad7594ba9 bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester 43ae381e09da bug 1533831: remote: disable remote agent; r=ochameau 5f26148983ed bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia 67512977e99e bug 1546385: remote: listen for target to connect sooner; r=ochameau cd550ea7c14e Backed out 4 changesets (bug 1533831) for failing at /browser/browser_target.js on a CLOSED TREE. 27e61a228567 bug 1533831: remote: run bc tests as part of regular batch; r=ochameau 559a398f9289 bug 1533831: remote: include remote agent in default build; r=firefox-build-system-reviewers,chmanchester eeb4b7175b28 bug 1533831: remote: disable remote agent; r=ochameau a22f7522c5e1 bug 1533831: remote: remove browser.fission.simulate pref; r=ochameau,yulia 0877dde4dea6 bug 1543676: remote: avoid Preferences.jsm before first paint; r=yulia 48a04afb1c4c Merge mozilla-central to autoland. CLOSED TREE 71d98ebd4c52 Backed out changeset bfaec0e9d5d8 (bug 1542198) as per request. a=backout a47443e812dd bug 1543679: remote: remove unused server files; r=ochameau,yulia
Work
- Current milestone
- MVP dependency tree
- General overview
- Puppeteer dependency tree
- All ze boogs
PTO (🌷)
- ato away 6 May (Bank Holiday)
- ochameau away Wednesday 1 May (Labour Day) Friday 3 May